Closed Bug 1546884 Opened 3 years ago Closed 3 years ago

Fix incorrect third-party check for traffic category

Categories

(Core :: Networking, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: xeonchen, Assigned: xeonchen)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

In [1] we detect if a channel is a third-party channel, but it actually checks for third-party tracking channel, which is wrong.

[1] https://searchfox.org/mozilla-central/rev/d143f8ce30d1bcfee7a1227c27bf876a85f8cede/netwerk/protocol/http/nsHttpChannel.cpp#1335

|mThirdPartyClassificationFlags| can only check for third-party tracking channel, it should be checked by calling |IsThirdPartyWindowOrChannel|.

Pushed by xeonchen@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/010e3e339377
fix third-party channel checks; r=dragana
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.