1546889 - Update Default Browser toast message

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Diana Iacos]

Following the patch for Bug 1544589 we need to update the toast message from "Tap Browser App & select &brandShortName;" to "Tap Browser app & select &brandShortName;"

Comment 1

[Diana Iacos]

Attachment: Bug 1546889 - Update Default Browser toast message; r?petru

Comment 2

[Diana Iacos]

Attachment: Bug 1546889 - Refresh Settings layout if default browser was changed while in background; r?petru

Handle 2 specific edge-cases:

• The user presses to change default browser, when he returns to the app the
  app settings button to do so should not be displayed anymore.
• With the app in background showing the app settings the user changes to a
  different default browser. When resuming the app it should show the option to
  set Fennec as default.
  All this without otherwise requiring the user to close app settings and opening
  them again.

Depends on D28831

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e97cf660ef3c
Update Default Browser toast message; r=petru,flod
https://hg.mozilla.org/integration/autoland/rev/181f0144ce7a
Refresh Settings layout if default browser was changed while in background; r=petru

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/e97cf660ef3c
https://hg.mozilla.org/mozilla-central/rev/181f0144ce7a

Comment 5

[Chris Peterson [:cpeterson]]

I've verified that the new "Tap Browser app & select Nightly" toast message works correctly in Fennec Nightly. It looks great!

Comment 6

[Chris Peterson [:cpeterson]]

Comment on attachment 9060707 [details]
Bug 1546889 - Update Default Browser toast message; r?petru

Beta/Release Uplift Approval Request

• User impact if declined: Fennec 67's toast message with instructions for setting Fennec as your default browser won't exactly match the menu item names in the Android system settings.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: 1. Open Fennec's settings menu.

2. See the "Make Nightly your default browser" menu item.
3. Tap the "Make Nightly your default browser" menu item.
4. See the "Tap Browser app & select Nightly" toast message.

• List of other uplifts needed: Bug 1544589
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Risk from refactoring some UI code and adding a new string. This patch is the first in a series to be landed in a specific order. The patches in bug 1544589 must land first.
• String changes made/needed: New string pref_default_browser2 "Make &brandShortName; your default browser", but I've been coordinating with the L10n team and the new string has been localized to 34+ languages.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9060707 [details]
Bug 1546889 - Update Default Browser toast message; r?petru

Uplift approved for 67 beta 15, thanks.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2642b7ac4a2e
https://hg.mozilla.org/releases/mozilla-beta/rev/d2c409855d16

Comment 9

[Stefan Deiac]

Verified as fixed on Beta 67.0b15 using Nexus 6P (Android 8.1.0) and Nokia 6 (Android 7.1.1).