Closed Bug 1546913 Opened 1 year ago Closed 1 year ago

Remove Callsides of nsIChannel::GetLoadinfo()

Categories

(Core :: DOM: Security, enhancement, P2)

66 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: sstreich, Assigned: sstreich)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:66.0) Gecko/20100101 Firefox/66.0

Currently we're doing this:


    nsCOMPtr<nsILoadInfo> loadInfo;
    rv = channel->GetLoadInfo(getter_AddRefs(loadInfo));
    NS_ENSURE_SUCCESS(rv, rv);
    NS_ENSURE_STATE(loadInfo);

while at the same time, we could simplify this with

    nsCOMPtr<nsILoadInfo> loadInfo = channel->LoadInfo();

This would also be a preperation to resolve Bug 152955

Type: defect → enhancement

Sorry i did mean Bug 1529554

Assignee: nobody → streich.mobile
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P2
Whiteboard: [domsecurity-active]
Keywords: checkin-needed

Pushed by opoprus@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/510c23dc30c6
Remove GetLoadInfo callsites r=ckerschb

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.