Closed Bug 1547069 Opened 2 years ago Closed 2 years ago

Enable screenshots by default for page timeout failures

Categories

(Testing :: Raptor, enhancement, P1)

Version 3
enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

Details

Attachments

(4 files)

As seen on bug 1506936 comment 46 an comment 47 it would be pretty helpful if Raptor would always screenshot the browser window when a failure occurs. Right now it is hidden behind a setting and needs manual try pushes for reproduction. That's time and infrastructure consuming.

Type: defect → enhancement
Priority: -- → P2
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P2 → P1

Capturing a screenshot for each and every failure would require way more work and refactoring. So I would suggest to simply take those when Raptor runs into a page load timeout.

Summary: Enable screenshots by default for failures (eg. timeouts) → Enable screenshots by default for page timeout failures

The method checkForResult is called each and every 5 milliseconds while the Raptor
tests are running. This actually consumes a lot of CPU which can decrease the
performance of the website under test.

It's totally enough to check for results 4 times in a minute.

Depends on D29175

Attachment #9061318 - Attachment description: Bug 1547069 - [raptor] Generalize code in waitForResult(). r=#perftest_reviewers → Bug 1547069 - [raptor] Generalize code in waitForResult(). r=#perftest-reviewers
Attachment #9061319 - Attachment description: Bug 1547069 - [raptor] Reduce CPU overhead when waiting for results. r=#perftest_reviewers → Bug 1547069 - [raptor] Reduce CPU overhead when waiting for results. r=#perftest-reviewers
Attachment #9061320 - Attachment description: Bug 1547069 - [raptor] Refactoring screen capturing code in web extension. r=#perftest_reviewers → Bug 1547069 - [raptor] Refactoring screen capturing code in web extension. r=#perftest-reviewers
Attachment #9061321 - Attachment description: Bug 1547069 - [raptor] Always take a screenshot on page load timeouts. r=#perftest_reviewers → Bug 1547069 - [raptor] Always take a screenshot on page load timeouts. r=#perftest-reviewers
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/799e477bd09d
[raptor] Generalize code in waitForResult(). r=perftest-reviewers,rwood
https://hg.mozilla.org/integration/autoland/rev/6d5bec8df2bc
[raptor] Reduce CPU overhead when waiting for results. r=perftest-reviewers,rwood
https://hg.mozilla.org/integration/autoland/rev/3e2c79019576
[raptor] Refactoring screen capturing code in web extension. r=perftest-reviewers,rwood
https://hg.mozilla.org/integration/autoland/rev/29e3098206ea
[raptor] Always take a screenshot on page load timeouts. r=perftest-reviewers,rwood
Regressions: 1548191
No longer regressions: 1548191
You need to log in before you can comment on or make changes to this bug.