Closed
Bug 1547115
Opened 4 years ago
Closed 4 years ago
Logpoints on Gmail in large prettified file completely freezes main thread
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox68 fixed)
RESOLVED
FIXED
Firefox 68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: Harald, Assigned: loganfsmyth)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
What were you doing?
- Open Gmail and log in
- In DevTools Inspector, pick the
body
elementsevents
bubble and find the click event (points tohttps://mail.google.com/_/scs/mail-static/_/js/k=gmail.main.en.…/m=b
in my case) - Click through to the file to open it in Debugger
- Should land on
b.addEventListener(c.toString(), e, f);
- Add a logpoint on that line, logging
c, e, f
- Refresh page
What happened?
Logs are coming in until Firefox's main UI freezes. Closing Debugger works and "thaws" Firefox.
What should have happened?
No freezing, just happy logging.
Anything else we should know?
addSources
and insertSourceActors
change redux state and cause codemirror to do expensive renderings on the large prettified file by calling disableEmptyLines
in resource://devtools/client/debugger/src/components/Editor/EmptyLines.js
. This seems to happen continuesly, even though nothing in the debugger changes.
Assignee | ||
Comment 1•4 years ago
|
||
I think I introduced this in https://phabricator.services.mozilla.com/D24443 by making the empty line selector non-memoized. I'll verify.
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → lsmyth
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•4 years ago
|
||
Pushed by lsmyth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5293fd5ae92f Memoize breakableLines to avoid resetting in editor often. r=jlast
Comment 4•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in
before you can comment on or make changes to this bug.
Description
•