154721 - Active Accessibility: focus events not working on documents

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

When a document is focused, GetFocusedElement() returns null, and thus
GetAccFocused() cannot create an accessible.

I have a patch forthcoming that changed GetFocusedElement() to GetFocusedNode(),
which will return the document node when the document is focused.

This fixes the situations.

Comment 1

[Aaron Leventhal]

Attachment: Changes GetFocusedElement() to GetFocusedNode(), which can now see document dom node focus. Also changes Accessible.cpp so that it fires focus events again.

seeking r=

Comment 2

[Kyle Yuan]

Comment on attachment 89490 [details] [diff] [review]
Changes  GetFocusedElement() to GetFocusedNode(), which can now see document dom node focus. Also changes Accessible.cpp so that it fires focus events again.

r=kyle

Yes, GetFocusedNode is more reasonable.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 89490 [details] [diff] [review]
Changes  GetFocusedElement() to GetFocusedNode(), which can now see document dom node focus. Also changes Accessible.cpp so that it fires focus events again.

+  /*
+  // Remove this until we can figure out which focus events are coming at
+  // the same time as native window focus events, although
+  // perhaps 2 duplicate focus events on the window isn't really a problem
...
+  */

Please use #if 0 ... #endif to take out blocks of code, using comments is error
prone...

sr=jst

Comment 4

[Aaron Leventhal]

checked in a while back.