1547263 - Picture-in-Picture player window controls won't fade away if the mouse exits the player window onto a non-Firefox window

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

Steps to reproduce:

1. Launch Nightly
2. Go to Youtube https://youtube.com
3. Select any video to play, and hover the video with the mouse
4. Click on the "Picture-in-Picture" toggle to open the video in the PiP window
5. Re-arrange your desktop so that there are no Firefox windows behind the Picture-in-Picture player window
6. Hover the mouse over the player window, and notice that the controls are visible
7. Move the mouse off of the player window onto some other space on the Desktop that is not a Firefox window

Expected Result:
The controls should fade out.

Actual Result:
The controls do not fade out.

Note:
This is a Windows only issue.

I suspect we need to listen for the WM_NCMOUSELEAVE message as well as WM_MOUSELEAVE.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I suspect this is the same thing as bug 1551961.

Comment 2

[Dão Gottwald [:dao]]

Maybe related to this, these listeners should probably use mouseenter and mouseleave instead: https://searchfox.org/mozilla-central/rev/928742d3ea30e0eb4a8622d260041564d81a8468/toolkit/content/widgets/videocontrols.js#2417,2423

Comment 3

[Mike Conley (:mconley) (:⚙️)]

This appears to be fixed now that bug 1551961 is fixed.

Comment 4

[Cristian Craciun]

Build ID 20190716001037
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Verified as fixed on the latest Nightly build (70.0a1) and latest Beta build (69.0b4) on Windows 10.