Closed Bug 1547264 Opened 5 years ago Closed 5 years ago

Annotate previously reviewed diffs in the history tab

Categories

(Conduit :: Phabricator, enhancement)

Product:
Conduit
Component:
Phabricator
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1470340

People

(Reporter: ahal, Unassigned)

Details

Sometimes patch authors can submit many diffs of their changes. As a reviewer, it can sometimes be difficult to figure out which diff was the one that we previously reviewed, and so it's hard to select the proper interdiff. Currently we need to read the change history, find our review, then search upwards to find which diff it was for.

It would be great if the history tab had a reviews column which contained an icon (either check mark or X) for any associated reviews for that diff. This gets a little bit more complicated if there were multiple reviews from different people on the same diff. A nice way of handling this might be to display multiple icons with the author name being displayed in a tooltip.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.