1547301 - Add openViewOnFocus API

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Mike de Boer [:mikedeboer]]

For more info, see the design doc over at https://docs.google.com/document/d/11c-OTsscmArnqL02Kq1TUPKtkHl4avmC3pDdSJDC6JI/edit

Simply enables sticky-view mode that is implemented directly in quantumbar.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1547301 - Add openViewOnFocus API. r=mak,mixedpuppy

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93ccef162814
Add openViewOnFocus API. r=mak,mixedpuppy

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest leaks on browser_page_bringToFront.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/103207464831538a5c9d74ac66ae901e306e72f4
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=252328090&repo=autoland&lineNumber=2424

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9e24264e20d
Add openViewOnFocus API. r=mak,mixedpuppy

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on UrlbarInput.jsm

Backout link: https://hg.mozilla.org/integration/autoland/rev/96b75db0403d0a060e5fe7518320e077896b3ea8
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=252351646&repo=autoland&lineNumber=5580

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/674aabaec2c4
Add openViewOnFocus API. r=mak,mixedpuppy

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/674aabaec2c4

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 9071263 [details]
Bug 1547301 - Add openViewOnFocus API. r=mak,mixedpuppy

Beta/Release Uplift Approval Request

• User impact if declined: this is needed for the first quantumbar experiment (bug 1547279)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): doesn't affect vanilla Firefox
• String changes made/needed:

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9071263 [details]
Bug 1547301 - Add openViewOnFocus API. r=mak,mixedpuppy

marco says we don't need this in 68

Comment 10

[lol768]

For more info, see the design doc over at https://docs.google.com/document/d/11c-OTsscmArnqL02Kq1TUPKtkHl4avmC3pDdSJDC6JI/edit

Can you open this up to the public please (also curious as to why this wouldn't be the default permissions choice)?