Closed Bug 1547307 Opened 4 months ago Closed 4 months ago

Make Source data actions explicitly operate on the redux store

Categories

(DevTools :: Debugger, task, P2)

task

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: loganfsmyth, Assigned: loganfsmyth)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Right now source actions all tend to go through one 'addSources' and 'updateSource' function that can update any number of fields and generally make it unclear what actions perform what mutations. Ideally different actions should clearly mutate specific subsets of source properties.

Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af328167fa26
Part 1: Remove the JsSource/WasmSource type distinction. r=jlast
https://hg.mozilla.org/integration/autoland/rev/87338e26a21e
Part 2: Convert UPDATE_SOURCE action for specific usecase. r=jlast
https://hg.mozilla.org/integration/autoland/rev/105886e67ebb
Part 3: Make blackbox-update a standalone function. r=jlast
https://hg.mozilla.org/integration/autoland/rev/fc69b2a78289
Part 4: Remove unused createSource function. r=jlast
https://hg.mozilla.org/integration/autoland/rev/9ab44b7c5516
Part 5: Recalculate relative URL on add/root-edit. r=jlast
https://hg.mozilla.org/integration/autoland/rev/60d4d3824604
Part 6: Ensure that we don't try to add the same Source multiple times. r=jlast
Regressions: 1568895
You need to log in before you can comment on or make changes to this bug.