Closed Bug 1547353 Opened 9 months ago Closed 5 months ago

MacOS selection color is oversaturated when gfx.color_management.mode = 1

Categories

(Core :: GFX: Color Management, defect, P3)

Desktop
macOS
defect

Tracking

()

VERIFIED FIXED
mozilla70
Tracking Status
firefox70 --- verified
firefox71 --- verified

People

(Reporter: ntim, Assigned: ruchikag826)

Details

(Keywords: good-first-bug)

Attachments

(3 files)

https://dxr.mozilla.org/mozilla-central/rev/7e40e33da3da2640e965a153254594a234231f76/widget/nsXPLookAndFeel.cpp#889-896

        if (transform) {
          uint8_t color[3];
          color[0] = NS_GET_R(aResult);
          color[1] = NS_GET_G(aResult);
          color[2] = NS_GET_B(aResult);
          qcms_transform_data(transform, color, color, 1);
          aResult = NS_RGB(color[0], color[1], color[2]);
        }

needs to change to:

        if (transform) {
          uint8_t color[4];
          color[0] = NS_GET_R(aResult);
          color[1] = NS_GET_G(aResult);
          color[2] = NS_GET_B(aResult);
          color[3] = NS_GET_A(aResult);
          qcms_transform_data(transform, color, color, 1);
          aResult = NS_RGBA(color[0], color[1], color[2], color[3]);
        }
Keywords: good-first-bug

The priority flag is not set for this bug.
:jbonisteel, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jbonisteel)
Flags: needinfo?(jbonisteel)
Priority: -- → P3

hello, Is this still open? I would like to take this up?

(In reply to Ruchika Gosain from comment #3)

hello, Is this still open? I would like to take this up?

Yep, please let me know if you've got any questions :)

Here's a newer link to the relevant code: https://searchfox.org/mozilla-central/rev/597a69c70a5cce6f42f159eb54ad1ef6745f5432/widget/nsXPLookAndFeel.cpp#892-899

Assignee: nobody → ruchikag826
Status: NEW → ASSIGNED
Attachment #9087757 - Attachment description: Bug 1547353 - MacOS selection color is oversaturated when gfx.color_management.mode = 1 → Bug 1547353 - MacOS selection color is oversaturated when gfx.color_management.mode = 1 r=ntim
Attachment #9087757 - Attachment description: Bug 1547353 - MacOS selection color is oversaturated when gfx.color_management.mode = 1 r=ntim → Bug 1547353 - MacOS selection color is oversaturated when gfx.color_management.mode = 1.
Attachment #9087757 - Attachment description: Bug 1547353 - MacOS selection color is oversaturated when gfx.color_management.mode = 1. → Bug 1547353 - Fix macOS selection color when gfx.color_management.mode = 1.
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/74bee2c675ad
Fix macOS selection color when gfx.color_management.mode = 1. r=nical
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

perumeni, could you please confirm this is fixed in the latest Nightly ? Thanks :)

Flags: qe-verify+
Flags: needinfo?(perumeni)

(In reply to Tim Nguyen :ntim from comment #9)

perumeni, could you please confirm this is fixed in the latest Nightly ? Thanks :)

Yes, all fine.

Flags: needinfo?(perumeni)

(In reply to perumeni from comment #10)

(In reply to Tim Nguyen :ntim from comment #9)

perumeni, could you please confirm this is fixed in the latest Nightly ? Thanks :)

Yes, all fine.

Setting the firefox71 flag to verified based on the above.
I could test the uplift if some details on the broken and intended result would be provided. Thanks!

Flags: needinfo?(perumeni)
OS: Unspecified → macOS
Hardware: Unspecified → Desktop

The intended result would be the result you see gfx.color_management.mode set to its default value (which is 2). If both values (1 and 2) give the same result, then I would consider this as verified :)

Attached image wiki_selection.png

With full color management (gfx.color_management.mode=1) intended as on the right.
But full is not enabled by default yet bug 455077.

Flags: needinfo?(perumeni)

(In reply to Tim Nguyen :ntim from comment #12)

The intended result would be the result you see gfx.color_management.mode set to its default value (which is 2). If both values (1 and 2) give the same result, then I would consider this as verified :)

According to the details received in comment 12 and my testing results:

  1. The lighter focused text selection is displayed when "gfx.color_management.mode" = 1 and a darker focused text color is displayed when the pref has value 2. All this on Firefox Release v69.0, the affected build.
  2. On Beta v70.0b3 and Nightly v71.0a1, the lighter focused text color is observable when the pref has value 1 and when it is 2.
    Based on the above information, I will mark this bug as verified. It was tested on Mac OS 10.14.6, 10.15 and 10.13.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.