Use HTML input instead of XUL textbox in toolkit/content/widgets/tree.js
Categories
(Toolkit :: UI Widgets, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | verified |
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(1 file)
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
Just to update the status here after talking with Tim. These are probably the hardest instances to deal with from Bug 1547372 since it interacts with absolute positioning and xul flexbox.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
•
|
||
As a workaround to the positioning issue, we could position a new XUL <box> element using XUL positioning instead of the HTML input itself and place the HTML input inside that XUL <box>.
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
||
Comment 6•5 years ago
|
||
| verification-steps | ||
If would be good to verify that our editable trees still work properly after this change. I know of two of them:
- Keyword column of about:preferences#search
- Username and password (after toggling passwords) columns of chrome://passwordmgr/content/passwordManager.xul (you can get access to this instead of about:logins by setting the pref
signon.management.overrideURIto an empty string in about:config.
It would be good to verify that the inline editing feature of these cells still work properly after this change.
|
|
||
Updated•5 years ago
|
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/10d80ce76790 Use HTML input instead of XUL textbox in toolkit/content/widgets/tree.js. r=MattN
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
|
||
Comment 9•5 years ago
|
||
Hi, This issue is Verified as Fixed in 70.0a1 (2019-07-24) on Windows 10, Ubuntu and MacOSX.
I have tested using the steps from Comment 6.
"Keyword column of about:preferences#search
Username and password (after toggling passwords) columns of chrome://passwordmgr/content/passwordManager.xul (you can get access to this instead of about:logins by setting the pref signon.management.overrideURI to an empty string in about:config."
Everything works properly.
Description
•