Closed Bug 1547382 Opened 4 years ago Closed 3 years ago

Use HTML input instead of XUL textbox in toolkit/content/widgets/tree.js

Categories

(Toolkit :: XUL Widgets, task, P5)

task

Tracking

()

VERIFIED FIXED
mozilla70
Tracking Status
firefox70 --- verified

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file)

No description provided.
Priority: -- → P5

Just to update the status here after talking with Tim. These are probably the hardest instances to deal with from Bug 1547372 since it interacts with absolute positioning and xul flexbox.

Type: defect → task

As a workaround to the positioning issue, we could position a new XUL <box> element using XUL positioning instead of the HTML input itself and place the HTML input inside that XUL <box>.

Attachment #9061124 - Attachment description: Bug 1547382 - Use HTML input instead of XUL textbox in toolkit/content/widgets/tree.js → Bug 1547382 - Use HTML input instead of XUL textbox in toolkit/content/widgets/tree.js. r=aswan

If would be good to verify that our editable trees still work properly after this change. I know of two of them:

  • Keyword column of about:preferences#search
  • Username and password (after toggling passwords) columns of chrome://passwordmgr/content/passwordManager.xul (you can get access to this instead of about:logins by setting the pref signon.management.overrideURI to an empty string in about:config.

It would be good to verify that the inline editing feature of these cells still work properly after this change.

Flags: qe-verify+
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/10d80ce76790
Use HTML input instead of XUL textbox in toolkit/content/widgets/tree.js. r=MattN
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Hi, This issue is Verified as Fixed in 70.0a1 (2019-07-24) on Windows 10, Ubuntu and MacOSX.

I have tested using the steps from Comment 6.

"Keyword column of about:preferences#search
Username and password (after toggling passwords) columns of chrome://passwordmgr/content/passwordManager.xul (you can get access to this instead of about:logins by setting the pref signon.management.overrideURI to an empty string in about:config."

Everything works properly.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Regressions: 1606018
You need to log in before you can comment on or make changes to this bug.