Closed Bug 1547494 Opened 5 years ago Closed 5 years ago

SyntaxError: redeclaration of let MozStatusbarpanel in generalBindings.js

Categories

(Thunderbird :: Filters, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 68.0

People

(Reporter: aceman, Assigned: aceman)

Details

Attachments

(1 file)

Just opening filter list dialog (Tools->Message filters), I get:
SyntaxError: redeclaration of let MozStatusbarpanel in generalBindings.js:1:1

Maybe because the FilterListDialog.xul imports both generalBindings.js and also customElements.js, which import generalBindings.js again.

Attached patch 1547494.patchSplinter Review
Attachment #9061182 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9061182 [details] [diff] [review]
1547494.patch

Review of attachment 9061182 [details] [diff] [review]:
-----------------------------------------------------------------

Thx! r=mkmelin
Attachment #9061182 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1b88307f4cbb
do not import generalBindigs.js twice in FilterListDialog.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: