Closed Bug 1547496 Opened 4 months ago Closed 4 months ago

Changing minimum font size no longer affects pref UI (but still shows a warning)

Categories

(Firefox :: Preferences, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: mkaply, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

This is a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1528712 based on mozregression.

Before bug 1528712, when you changed the Minimum font size in preference, it affects the fonts in preferences as well. We have a warning because of that:

"You have selected a very large minimum font size (more than 24 pixels). This may make it difficult or impossible to use some important configuration pages like this one."

After bug 1528712, fonts in preferences are not changed by the minimum font size pref.

I'm concerned this affects other default font sizes.

Either way, I don't believe this was an expected side effect and should be investigated.

That's actually a sort-of expected difference from that change, see:

https://phabricator.services.mozilla.com/D20141#inline-110236

The checks were inconsistent before that, but I'm happy to change them so all the minimum font-size checks apply to documents in chrome docshells (which won't include about:preferences), not chrome documents (which does).

Are we 100% sure that we want to make min-font-size apply to chrome docs that are loaded in type="content" docshells? If so I can send a patch.

Flags: needinfo?(gijskruitbosch+bugs)
Flags: needinfo?(dao+bmo)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

Are we 100% sure that we want to make min-font-size apply to chrome docs that are loaded in type="content" docshells?

I defer to Dão on this but I don't think there's a great necessity for this. On Windows and Linux (less sure about macOS), I believe OS font size will influence the UI in this case (worth doublechecking). If Dão agrees with me, we should remove the warning.

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to :Gijs (he/him) from comment #2)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

Are we 100% sure that we want to make min-font-size apply to chrome docs that are loaded in type="content" docshells?

I defer to Dão on this but I don't think there's a great necessity for this. On Windows and Linux (less sure about macOS), I believe OS font size will influence the UI in this case (worth doublechecking). If Dão agrees with me, we should remove the warning.

Yeah, I think that's right.

Component: Layout: Text and Fonts → Preferences
Flags: needinfo?(dao+bmo)
Product: Core → Firefox

I've confirmed that on win10, changing the system font size affects preferences in nightly.

I don't think this is crucial to fix for 67 so I'll just put up a fix for 68.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Priority: -- → P1

This warning was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1047586 .
As a result of https://bugzilla.mozilla.org/show_bug.cgi?id=1528712 , internal pages
are no longer affected by this change. Instead, they obey the OS font size
configuration, in which we cannot warn. So let's remove the now-inaccurate warning dialog.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7abd077c8294
remove warning for minimum font sizes being big as internal pages are no longer affected, r=mconley,flod
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.