"View History Sidebar" menu is missing label for in Library toolbutton > History
Categories
(Firefox :: Toolbars and Customization, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox66 | --- | unaffected |
| firefox67 | --- | unaffected |
| firefox68 | --- | verified |
People
(Reporter: alice0775, Assigned: umaralam48)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files)
image.png
Steps to reproduce:
- Click on Library toolbutton in Nav bar
- Click on History
Actual Results:
No label, see attached screen shot
Expected Results:
The label should be "View History Sidebar"
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c1b7457b258ac27b7d737160fdb859c2648d9d90&tochange=33363b7f728c5f4a61ccf7f890ab6f1140a5ef95
Regressed by: 33363b7f728c Mohd Umar Alam — Bug 1533533-Add a label to hide synced tabs sidebar when it is shown r=sfoster,jaws,flod
:umaralam48,
Your patch seems to cause the regression. Can you look into this?
|
Reporter | |
Updated•5 years ago
|
|
|
Reporter | |
Comment 1•5 years ago
|
||
Hamburger menu is also affected.
Hamburger > Library > History
|
|
Reporter | |
Comment 2•5 years ago
|
||
Once you run the menu, you will see the label next time.
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
Thanks for pointing that out. This patch fixes it.
|
||
Updated•5 years ago
|
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb532b01e592 View History Sidebar menu is missing label for in Library toolbutton r=jaws
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
|
||
Comment 7•5 years ago
|
||
Hello
The issue was reproduced with Firefox 68.0a1 (20190428221317) on Windows 10 x64, macOS 10.14, Ubuntu 18.04.
The fix is verified with Firefox 68.0a1 (20190509033505) on Windows 10 x64, macOS 10.14, Ubuntu 18.04
Description
•