"View History Sidebar" menu is missing label for in Library toolbutton > History

VERIFIED FIXED in Firefox 68

Status

()

defect
P1
normal
VERIFIED FIXED
3 months ago
2 months ago

People

(Reporter: alice0775, Assigned: umaralam48)

Tracking

(Regression, {regression})

68 Branch
Firefox 68
Desktop
Windows 10
Points:
---

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox66 unaffected, firefox67 unaffected, firefox68 verified)

Details

Attachments

(3 attachments)

Posted image image.png

Steps to reproduce:

  1. Click on Library toolbutton in Nav bar
  2. Click on History

Actual Results:
No label, see attached screen shot

Expected Results:
The label should be "View History Sidebar"

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c1b7457b258ac27b7d737160fdb859c2648d9d90&tochange=33363b7f728c5f4a61ccf7f890ab6f1140a5ef95

Regressed by: 33363b7f728c Mohd Umar Alam — Bug 1533533-Add a label to hide synced tabs sidebar when it is shown r=sfoster,jaws,flod

:umaralam48,
Your patch seems to cause the regression. Can you look into this?

Flags: needinfo?(umaralam48)
Has Regression Range: --- → yes
Has STR: --- → yes
Posted image image.png

Hamburger menu is also affected.

Hamburger > Library > History

Once you run the menu, you will see the label next time.

Thanks for pointing that out. This patch fixes it.

Flags: needinfo?(umaralam48)
Assignee: nobody → umaralam48
Priority: -- → P1
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eb532b01e592
View History Sidebar menu is missing label for in Library toolbutton r=jaws
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Hello
The issue was reproduced with Firefox 68.0a1 (20190428221317) on Windows 10 x64, macOS 10.14, Ubuntu 18.04.
The fix is verified with Firefox 68.0a1 (20190509033505) on Windows 10 x64, macOS 10.14, Ubuntu 18.04

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.