1547616 - warning message about changes to profiles.ini by other Firefox process shows literal '-brand-product-name' because variable is not defined in Gecko 67

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1529879 added the following strings to Gecko 67:

toolkit/locales/en-US/toolkit/about/aboutProfiles.ftl
profiles-conflict = Another copy of { -brand-product-name } has made changes to profiles. You must restart { -brand-short-name } before making more changes.

toolkit/locales/en-US/chrome/mozapps/profile/profileSelection.properties
# LOCALIZATION NOTE (conflictMessage): %1$S is brandProductName, %2$S is brandShortName.
conflictMessage=Another copy of %1$S has made changes to profiles. You must restart %2$S before making more changes.

Those brand product name variable got added to Gecko 68 in bug 1539620 and are currently missing for Gecko 67.

Thus instead of the product name "Firefox", the plain variable name name will be shown for ftl version. Haven't checked if the .properties version throws an error and aborts or shows 'undefined' instead.

Francesco, should those be replaced with new strings?

Comment 1

[Francesco Lodolo [:flod]]

The problem is that I wasn't expecting bug 1529879 to be uplifted at the end of a Beta cycle, and I didn't consider that when i got pinged over IRC for the uplift.

At this point, the cleanest solution would be to uplift bug 1539620, so that existing strings work. Those brand names will fall back to "Firefox", which is what we want anyway.

CCing Pike, because I'm supposed to not be much online until May 2, and that would be too late.

Comment 2

[Francesco Lodolo [:flod]]

Note: the alternative to uplifting bug 1539620 is backing out this patch (bug 1529879), not creating new strings for Beta.

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

No need to track as we are uplifting bug 1539620.

Comment 4

[Dave Townsend [:mossop]]

Gah, sorry. For some reason I was under the impression that bug 1539620 was already uplifted.

Comment 5

[Dave Townsend [:mossop]]

This was fixed by the uplift in bug 1539620