1547631 - Thunderbird 67 for Windows 32bit can not install Windows 32bit for non-en-US builds

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[fylgja]

Attachment: Thunderbird67-32bit can not install Windows-32bit

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

1. download Thunderbird 67 Win32 from
   http://ftp.mozilla.org/pub/thunderbird/releases/67.0b2/win32/en-GB/Thunderbird%20Setup%2067.0b2.exe
2. run Thunderbird%20Setup%2067.0b2.exe on Windows 7 32bit.

Actual results:

Setup.exe display dialog "Sorry, Thunderbird can't be installed.
This version of Thunderbird requires Microsoft Windows 7 x64 or newer.
Please click the OK button for additional information.", can not continue setup.

Expected results:

Setup.exe setup Thunderbird-32bit on Windows-32bit.

releases/66.0b1/win32 unaffected
releases/66.0b2/win32 unaffected
releases/66.0b3/win32 unaffected
releases/67.0b1/win32 affected
releases/67.0b2/win32 affected

Comment 1

[fylgja]

Workaround:

1. Download and extract win32/66.0b3
2. Download and extract win32/67.0b2
3. Copy 66.0b3/Setup.exe to 67.0b2/Setup.exe
4. Run Setup.exe

Additional Info:

win32/66.0b3/Setup.exe include string "Target CPU : x86"
win32/67.0b2/Setup.exe include string "Target CPU : x64"

Comment 2

[Wayne Mery (:wsmwk)]

Comment 0 cites downloading en-GB.
Does this reproduce with the en-US version?

Comment 3

[fylgja]

67.0b2/win32/en-US: can not reproduce
67.0b2/win32/en-GB: reproduce
67.0b2/win32/es-ES: reproduce
67.0b2/win32/es-AR: reproduce
67.0b2/win32/pt-BR: reproduce
67.0b2/win32/pt-PT: reproduce
67.0b2/win32/zh-CN: reproduce
67.0b2/win32/zh-TW: reproduce
67.0b2/win32/de: reproduce
67.0b2/win32/fr: reproduce
67.0b2/win32/it: reproduce
67.0b2/win32/ru: reproduce
67.0b2/win32/ja: reproduce
67.0b2/win32/ko: reproduce

Comment 4

[Wayne Mery (:wsmwk)]

Thanks for checking.

What strangeness is this?

Comment 5

[Jorg K (CEST = GMT+2)]

Sorry, can't help, I don't have Win7 and I don't have any 32bit Windows either. Richard, do you?

Does an equivalent Firefox build behave the same?

Comment 6

[Richard Marti (:Paenglab)]

I have no 32bit Windows.

fylgja, can you check the 67.0b2/win32/en-US what Target CPU it shows?

Comment 7

[fylgja]

Attachment: left: en-us, right: en-gb

win32/en-US Setup.exe : "Target CPU : x86"
win32/en-GB Setup.exe : "Target CPU : x64"

Comment 8

[Richard Marti (:Paenglab)]

Thanks, so it seems the localized builds are packaged wrongly.

Comment 9

[fylgja]

nightly 66.0a1 BuildID:20190128074841
en-US : not reproduce
en-GB : not reproduce

nightly 67.0a1 BuildID:20190201085418
en-US : not reproduce
en-GB : reproduce

nightly 68.0a1 BuildID:20190501074419
en-US : not reproduce
en-GB : reproduce

These "Setup.exe" binary images are 32bit(Win32PE), not 64bit.
I think "Target CPU" probably used by/for NSIS,
but I don't know why there is a difference between en-US and non-en-US.

Comment 10

[Rob Lemley [:rjl]]

It looks like the goofup is happening in the l10n repackage step.

From nightly-l10n-win32-nightly-3 log on 2019-05-03:

11:33:14 INFO - z:/task_1556961714/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe z:/task_1556961714/build/src/config/nsinstall.py -D z:/task_1556961714/build/src/obj-firefox/dist/
11:33:14 INFO - (cd z:/task_1556961714/build/src/obj-firefox/dist/ &&
11:33:14 INFO - wget --no-cache -nv --no-iri -N -O thunderbird-68.0a1.en-US.win64.zip 'https://queue.taskcluster.net/v1/task/e06YNeRuRgy6KBfXnhTd8g/artifacts/public/build/target.zip')

... except that the zip file it grabs (target.zip URL) actually holds a 32-bit build. This indicates a problem with the task configuration. It's defaulting to building a 64 installer.

Comment 11

[Rob Lemley [:rjl]]

Firefox fixed a similar problem in bug 1523684.

Comment 12

[Rob Lemley [:rjl]]

Attachment: l10n_repack_target_x86.patch

Trees are closed at the moment, so I haven't run a build. However this is the same change that Firefox to fix the issue.

Will need uplifting to beta once a nightly build is verified.

Comment 13

[Jorg K (CEST = GMT+2)]

Comment on attachment 9062737 [details] [diff] [review]
l10n_repack_target_x86.patch

Looks OK to me, I'll land this with my next push.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a7c85aa61353
Port bug 1523684: Set 32-bit build target on win32 l10n repacks. r=jorgk

Comment 15

[Jorg K (CEST = GMT+2)]

Let's see how it goes.

Comment 16

[Rob Lemley [:rjl]]

Last night's build (2019-05-05) looks good to me.

Comment 17

[fylgja]

nightly 68.0a1 BuildID:20190505115815
en-GB : not reproduce
es-ES : not reproduce
zh-CN : not reproduce
fr : not reproduce
ru : not reproduce

RESOLVED FIXED
Thank you so much !

Comment 18

[Jorg K (CEST = GMT+2)]

TB 67 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/7fcb16ec50b1465f4bd0e95215bb45284b5f6ade