1547664 - "File > Empty Trash" incorrectly displays "Empty <current folder>" in confirmation dialog title

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Olivier Tilloy]

Attachment: tb-empty-trash.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) snap Chromium/74.0.3729.108 Chrome/74.0.3729.108 Safari/537.36

Steps to reproduce:

(originally reported at https://support.mozilla.org/en-US/questions/1254659 but it's not an Ubuntu-specific issue as replies in that thread seem to imply)

1. Select any folder under any account in the left pane (e.g. a folder named "Foo Bar")
2. Open the file menu and click "Empty Trash"
3. Observe that a confirmation dialog is displayed ("Delete all messages and subfolders in the Trash folder?")

Actual results:

The title of the dialog reads 'Empty "Foo Bar"'.

Expected results:

The title of the dialog should be 'Empty Trash'.

Comment 1

[:aceman]

And which folder does it actually empty?
I think we did this, because we also use this to empty the junk folder. But the context menu item to empty Junk or Trash shows only on the Junk and Trash folders. Not that this main menu item is active on any folder, but picks up the name of the current folder (but this one won't be emptied), this would be a bug.

Comment 2

[:aceman]

There is already a note about this weirdness in the code: https://searchfox.org/comm-central/source/mail/base/content/folderPane.js#2651 :)

Comment 3

[:aceman]

Attachment: 1547664.patch

Note that folder.emptyTrash() will look for a real trash folder anyway (server type dependent), it will not empty 'folder' unconditionally. So at least try to look for some real trash folder in the confirmation prompt.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9062698 [details] [diff] [review]
1547664.patch

Review of attachment 9062698 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me, thanks.

::: mail/base/content/folderPane.js
@@ +2646,5 @@
>    /**
>     * Prompts the user to confirm and empties the trash for the selected folder.
>     * The folder and its children are only emptied if it has the proper Trash flag.
>     *
> +   * @param aFolder (optional)  The trash folder to empty. If unspecified, the

If unspecified? Did you want to say "if unspecified or not a trash folder"?

Comment 5

[:aceman]

Yes.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7e7a8c180b0c
Ask for confirmation on the real trash folder if a non-trash folder was selected. r=jorgk

Comment 7

[Jorg K (CEST = GMT+2)]

TB 67 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/006b4646c4f2e12645fcc5b6afd53da71d50da20

Comment 8

[Jorg K (CEST = GMT+2)]

Well, that patch doesn't apply to comm-esr60 at all.

Comment 9

[Jorg K (CEST = GMT+2)]

TB 60.8 ESR:
https://hg.mozilla.org/releases/comm-esr60/rev/cf751a447cd83a52d0c046d4605c915ba400b26b