1547679 - Disable all browser-chrome tests on debug due to bug 1546945

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P1)

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1547679: remote: disable all browser-chrome tests on debug;

Before landing the remote agent in Firefox Nightly, we had to disable
remote/test/browser/browser_cdp.js because it caused a permafailure
on debug due to a memory leak. We thought the problem was limited
to this specific test, but over the weekend two more intermittent
leaks were discovered:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1546850
• https://bugzilla.mozilla.org/show_bug.cgi?id=1547303

Until we have had time to investigate and plug the leak, we will
disable all the browser-chrome tests on all debug platforms.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58ac3afa5e9a
remote: disable all browser-chrome tests on debug; r=remote-protocol-reviewers,ochameau

Comment 3

[Andrew McCreight [:mccr8]]

Please also disable them in ASan (Bug 1547303 is a leak detected by LeakSanitizer, which is run as part of AddressSanitizer.)

Comment 4

[Andreas Tolfsen ❲:ato❳]

(In reply to Andrew McCreight [:mccr8] from comment #3)

Please also disable them in ASan (Bug 1547303 is a leak detected
by LeakSanitizer, which is run as part of AddressSanitizer.)

Thanks for the head’s up!

I actually asked about this in meeting we had earlier today, about
why we hadn’t seen any fallouts in ASan jobs. I just assumed I
had misunderstood what ASan was about, but glad you confirmed my
original idea was the right one.

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/58ac3afa5e9a

Comment 6

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1547679: remote: disable browser-chrome tests on asan;

We should also disable browser-chrome tests on ASan, as some of
the leaks reported were caught by LeakSanitizer, which is run as
part of AddressSanitizer.

Follow-up from https://bugzilla.mozilla.org/show_bug.cgi?id=1547679#c3.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d59b5153250d
remote: disable browser-chrome tests on asan; r=remote-protocol-reviewers,ochameau

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d59b5153250d