1547695 - The "Try Again" button is missing on the error pages

Status: RESOLVED FIXED

(Firefox :: Security, defect, P1)

Description

[blinky]

Steps to reproduce:

• Go to about:neterror?e=connectionFailure

Actual results:

The "Try Again" button is missing on the error pages.

Comment 1

[blinky]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=09dab984c603ffc486e81d542a674babb4516fb4&tochange=46b2369b332c54ec61127c39344e32b156a14d53

Regressed by: bug 1530348

Comment 2

[Mariana Meireles]

Hey, I'm just starting to contribute to Firefox. I've done a few simple things already and I'd like to tackle some more difficult bugs (but not terribly complicated ones :o).
Is this a good issue for me?
Or maybe because Johann caused the regression he should fix it because he knows more about it?
Thanks!

Comment 3

[Johann Hofmann [:johannh]]

Hey Mariana, thank you for your interest and sorry for the delayed response. I'm not sure if this bug is a good bug to choose for you because it's a regression we will need to uplift (thus being a bit time-critical) and the issue is also just a bit annoying to deal with (we basically have two elements that both have the same ID and need to support the same functionality).

Would you want to look into bug 1363279? I just added some instructions there. You can also reach out to me on IRC if you have any other questions.

Thanks!

Comment 4

[Johann Hofmann [:johannh]]

Attachment: Bug 1547695 - De-dupe #errorTryAgain on about:neterror/certerror. r=prathiksha

We were using the same ID on two elements, which kind of messed up things everywhere
our code reasonably expected only one element of the kind to exist. We just use a
class name now.

This also cleans up #advancedPanelErrorTryAgain which worked around this issue
by using a different ID.

Comment 6

[Mariana Meireles]

Hi Johann, okay. Thanks for the directing me there & for offering further help! :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d59f5e3db1b
De-dupe #errorTryAgain on about:neterror/certerror. r=prathiksha

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7d59f5e3db1b

Comment 9

[Florencia Di Ciocco, NI to vbalducci]

Attachment: missing button

Hi guys,
I noticed that this bug is still occurring on some pages.
STR:

1. create a profile. Open FF using that profile "online". Go to https://1stkissmanga.com/manga/omniscient-readers-viewpoint/
2. Close FF and open it again with the same user but "offline". Go to the same page.

How can we proceed? Should I open a new bug? This happened on Windows 10 on nightly 82.0a1 (2020-09-01) (64-bit).

Regards, Flor.

Comment 10

[:Gijs (he/him)]

(In reply to Florencia Di Ciocco from comment #9)

STR:

1. create a profile. Open FF using that profile "online". Go to https://1stkissmanga.com/manga/omniscient-readers-viewpoint/
2. Close FF and open it again with the same user but "offline". Go to the same page.

How can we proceed? Should I open a new bug? This happened on Windows 10 on nightly 82.0a1 (2020-09-01) (64-bit).

Regards, Flor.

Please file a new bug with more detailed steps - I can't reproduce on a clean profile on Windows 10. Thanks!

Comment 11

[Florencia Di Ciocco, NI to vbalducci]

Hi,

So I opened bug 1662739. I was able to reproduce the bug every time and I attached a video for extra help.

Thanks for your reply, Flor.