1547697 - gecko profiler doesn't work in beta

Status: VERIFIED DUPLICATE of bug 1537626

(Thunderbird :: General, defect)

Description

[Wayne Mery (:wsmwk)]

Downloaded from https://raw.githubusercontent.com/devtools-html/Gecko-Profiler-Addon/master/gecko_profiler.xpi

Installed on beta (doesn't appear to work in release)

Profiler icon appears in Mail Toolbar, but Error console has

1556542120761 [e-mail] WARN Loading extension '[e-mail]': Reading manifest: Error processing permissions.0: Value "geckoProfiler" must either: must either [must either [be one of ["clipboardRead", "clipboardWrite", "geolocation", "idle", "notifications"], be one of ["accountsRead"], be one of ["addressBooks"], be one of ["menus.overrideContext"], be one of ["messagesMove", "messagesRead"], be one of ["activeTab", "tabs", "tabHide"], be one of ["browserSettings"], be one of ["cookies"], be one of ["downloads", "downloads.open"], be one of ["topSites"], be one of ["webNavigation"], or be one of ["webRequest", "webRequestBlocking"]], be one of ["alarms", "mozillaAddons", "storage", "unlimitedStorage"], be one of ["menus"], be one of ["pkcs11"], be one of ["contextualIdentities"], be one of ["dns"], be one of ["management"], be one of ["privacy"], be one of ["proxy"], be one of ["nativeMessaging"], be one of ["telemetry"], be one of ["theme"], or match the pattern /^experiments(.\w+)+$/], or must either [be one of ["<all_urls>"], must either [match the pattern /^(https?|wss?|file|ftp|*)://(*|*.[^/]+|[^/]+)/.$/, or match the pattern /^file:///.$/], or match the pattern /^resource://(*|*.[^/]+|[^/]+)/.*$|^about:/]
chromeModifierKeyMap is undefined ext-commands.js:286
1556542120800 addons.xpi WARN Exception running bootstrap method startup on [e-mail]: TypeError: chromeModifierKeyMap is undefined(chrome://messenger/content/parent/ext-commands.js:286:7) JS Stack trace: getModifiersAttribute/<@ext-commands.js:286:7
[e-mail]:285:18
[e-mail]:238:47
[e-mail]:190:27
registerKeysToDocument/<@ext-commands.js:166:39
[e-mail]:157:14
[e-mail]:77:12
[e-mail]:87:10
TypeError: chromeModifierKeyMap is undefined ext-commands.js:286:7
TypeError: browser.geckoProfiler is undefined background.js:235:3

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

Hmm I wonder why our command tests are not catching this. ShortcutUtils looks new.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

I've requested uplift in bug 1537626 which should fix this.

Comment 3

[Wayne Mery (:wsmwk)]

Thanks. I didn't realize it was only working in 68.