1547711 - Provide translations for JAWS-ESR one-off add-on.

Status: RESOLVED FIXED

(Mozilla Localizations :: Other, task)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

We are shipping an update for a jaws-esr add-on for our ESR60 users to attempt to migrate some of them to a newer Firefox version with e10s enabled. You can see the REPO for the add-on here:

https://github.com/mozilla/one-off-system-add-ons/tree/master/addons/jaws-esr

And incoming branch here:

https://github.com/yzen/one-off-system-add-ons/tree/jaws-esr-60/addons/jaws-esr

We are adding a new string to the add-on properties file that can be found here (note: it is finalized):

https://github.com/yzen/one-off-system-add-ons/blob/jaws-esr-60/addons/jaws-esr/locales/en-US/jaws-esr.properties#L9-L12

Original l10n repo is here:

https://github.com/mozilla-l10n/jaws-esr-addon-l10n

For more information please see:

https://docs.google.com/document/d/1dxQEnSJo3iMUSDAyONsXdWRwCGFESjFapkR_5yA9piE/edit?ts=5cbe5dda#

Comment 1

[Francesco Lodolo [:flod]]

You have a *S instead of %S in that string.

I've unarchived the repository, can you add your new string here?
https://github.com/mozilla-l10n/jaws-esr-addon-l10n/blob/master/locales/en-US/jaws-esr.properties

What's the deadline to have content localized?

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: GitHub Pull Request - added string.

The formal deadline is for it to be ready for Firefox 60ESR, which I believe is July 9th. Ideally we would want it ready earlier for testing etc. Do you know roughly how long it would take? Last time it took under a week, if I remember correctly to get 80 or 90 percent of translations (by user base).

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Yura Zenevich [:yzen] from comment #2)

Do you know roughly how long it would take?

Unfortunately we don't have data, but I'll try to expose this as soon as possible, and set a deadline around mid June.

Comment 4

[Francesco Lodolo [:flod]]

I've re-enabled the project. Just to confirm, you're using the standard getFormattedString() in code?

Asking because I used a printf trick to avoid a warning, since I don't want to use the second %S
https://github.com/mozilla-l10n/jaws-esr-addon-l10n/commit/5e891cdae427ef692e4ffb33db012a3bb19709fe

That works in Firefox, and it works in the add-on as long as you use the normal stringBundles methods.

Status: https://pontoon.mozilla.org/projects/jaws-esr-add-on/

I'm going to close this bug, feel free to poke me if you need more information later on.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Francesco Lodolo [:flod] from comment #4)

I've re-enabled the project. Just to confirm, you're using the standard getFormattedString() in code?

Asking because I used a printf trick to avoid a warning, since I don't want to use the second %S
https://github.com/mozilla-l10n/jaws-esr-addon-l10n/commit/5e891cdae427ef692e4ffb33db012a3bb19709fe

That works in Firefox, and it works in the add-on as long as you use the normal stringBundles methods.

Status: https://pontoon.mozilla.org/projects/jaws-esr-add-on/

I'm going to close this bug, feel free to poke me if you need more information later on.

In the previous version as well as the new one we are using formatStringFromName. Is that still OK?

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Just for context:

Old version:
https://github.com/mozilla/one-off-system-add-ons/blob/master/addons/jaws-esr/bootstrap.js#L58-L59

New version:
https://github.com/yzen/one-off-system-add-ons/blob/jaws-esr-60/addons/jaws-esr/bootstrap.js#L52-L54

Comment 7

[Francesco Lodolo [:flod]]

(In reply to Yura Zenevich [:yzen] from comment #5)

In the previous version as well as the new one we are using formatStringFromName. Is that still OK?

I assume so, since it's a nsIStringBundle method. In case, it would be easy to verify by testing the add-on on Italian.