1547721 - Add an Ion script size limit

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Description

[Jan de Mooij [:jandem]]

We have a script size limit for when off-thread compilation isn't available. When off-thread compilation is available, we compute Ion's warm-up threshold based on the script size, but this can still get out of control. For example bug 1536006 is the result of Ion compiling a script with bytecode length 154905.

On Octane the scripts with length > 10,000 we Ion compile are: 15475, 16150, 62078 bytes. That suggests a limit of 100,000 is probably a safe starting point.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1547721 - Add an Ion script size limit. r?tcampbell!

We had a script size limit (and number of locals/args limit) when off-thread Ion
compilation wasn't available, but no hard limit when off-thread compilation is
available. This patch addresses that.

This patch also converts the main-thread limits from constants to JitOptions
because that's what we use for new code.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0101502b8b7
Add an Ion script size limit. r=tcampbell

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c0101502b8b7