Closed
Bug 1547756
Opened 5 years ago
Closed 5 years ago
Consider removing the --register commandline flag
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
Details
Attachments
(1 file)
I don't see what the point of this code is in today's world (no more restartful add-ons, no more components outside omni.ja), but perhaps I'm missing something?
|
Assignee | |
Comment 1•5 years ago
|
||
The more you look at this, the more dead it looks, so out it goes.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
|
||
Comment 2•5 years ago
|
||
Yeah, we stopped caching chrome and components in bug 570488 and bug 568691 so this argument has probably been dead code for 9 years.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Apparently introduced by bryner back in 2002, and refactored numerous times without too much scrutiny, this:
- presumably was there for binary components (which are no longer supported)
- or external (add-on) restart-required components (ditto)
- or really any non-builtin components (ditto)
- and would presumably at one point store data somewhere... except that's kinda hard without a profile.
- seems to have never been documented, as far as I can tell.
So let's remove it.
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a558a6154748 remove support for -register commandline flag because it's bogus in 2019, r=froydnj
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•