Closed Bug 1547985 Opened 5 months ago Closed 5 months ago

Use rust types for vertical-align.

Categories

(Core :: CSS Parsing and Computation, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files)

No description provided.

They do nothing, if they get parsed, they end up doing the same as text-align:
start, which is the same that we'd get out of GetLogicalAlign if the attribute
wasn't parsed in the first place.

We don't use this attribute for anything else like attribute mapping, so this
should be an idempotent patch.

The previous commit removed the dependence on the discriminant value, so we
don't need to keep discriminants different from text-align anymore.

Depends on D29360

Type: defect → task
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/40c62969bc70
Stop parsing the legend align's top and bottom attributes. r=mats
https://hg.mozilla.org/integration/autoland/rev/5e3c456acd73
Use rust types for vertical-align. r=mats
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Regressions: 1570096
You need to log in before you can comment on or make changes to this bug.