1548042 - Special FxA Snippet on New Tab for Firefox 67

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ricky Rosario [:rrosario, :r1cky]]

This is a new special snippet template that renders below the search bar on newtab page. See Bug 1539700 for more details.

We would like to get this uplifted to beta as one commit for convenience and because we don't want individual pieces to be backed out (it's all or nothing).

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Ricky, do you have an ETA on the uplift? Also, it is my understandig that you want it for Trailhead, not for 67.0, can you confirm please? Thanks

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Pascal Chevrel:pascalc from comment #1)

Ricky, do you have an ETA on the uplift? Also, it is my understandig that you want it for Trailhead, not for 67.0, can you confirm please? Thanks

We just need to export the patch from the github repo, so we can have that done today. And we want this part to be uplifted to 67.0 (not Trailhead).

Comment 3

[Pascal Chevrel:pascalc (PTO until April 26)]

If it's not targeting our Trailhead release, maybe it shouldn't block bug 1545802.

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

Attachment: Bug 1548042 - Special FxA Snippet on New Tab for Firefox 67

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Comment on attachment 9063180 [details]
Bug 1548042 - Special FxA Snippet on New Tab for Firefox 67

Beta/Release Uplift Approval Request

• User impact if declined: Users won't see the new FXA snippet under the search box on about:newtab.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: The snippets team (:giorgos, :jcollings) will need to deploy a snippet that targets beta 67. Then the snippet will appear in the new spot on newtab page. See Bug 1539700 for more details.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is pretty big, mostly because it contains changes to the prerendered file for every single locale. But the actual changes aren't that complex and have been tested and verified on Nightly. Also, the snippet can be turned off from the snippets server if any issue were to come up.
• String changes made/needed: N/A

Comment 6

[Jessilyn Davis]

Joe and Reese - do you approve this uplift into 67.0 in support of Trailhead?

Comment 7

[Marissa (Reese) Wood]

2019-05-08 - This is approved. R+

Comment 8

[Joe Hildebrand [:jhildebrand] (UTC-6)]

r+

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9063180 [details]
Bug 1548042 - Special FxA Snippet on New Tab for Firefox 67

Evaluated as low risk, uplift approved for beta 19, thanks.

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/306b66355056

Comment 11

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Removing the qe-verify flag as we signed off (GREEN) on this feature via email on 5/15/2019. Link to test run.