Add profiler markers for dropped frames to aggregate media playback performance in the Profiler
Categories
(Core :: Audio/Video, enhancement, P2)
Tracking
()
People
(Reporter: Harald, Unassigned)
References
Details
Dropped frames in the decoder, sink and compositor should use the existing marker infrastructure to provide every occurrence of dropped frames (with potential meta data) to the Profiler.
The profiler can already expose those markers but also eventually have a media-focused track to aggregate those markers (not part of this bug).
|
Reporter | |
Updated•7 years ago
|
|
||
Comment 1•7 years ago
|
||
We have markers for video frames dropped in decode and in composite:
https://searchfox.org/mozilla-central/rev/f0ef51bfafc8ad0c3a2f523bf076edc57dc4891a/dom/media/mediasink/VideoSink.cpp#496
https://searchfox.org/mozilla-central/rev/f0ef51bfafc8ad0c3a2f523bf076edc57dc4891a/dom/media/mediasink/VideoSink.cpp#535
https://searchfox.org/mozilla-central/rev/f0ef51bfafc8ad0c3a2f523bf076edc57dc4891a/gfx/layers/composite/ImageComposite.cpp#115
https://searchfox.org/mozilla-central/rev/f0ef51bfafc8ad0c3a2f523bf076edc57dc4891a/dom/media/MediaFormatReader.cpp#2531
Do we need to do anything else here?
Note that (other than the compositor marker) the markers typically appear on one of the "Media" threads, so you need to add "Media" to the name of the threads being profiled in order to see these.
|
|
Reporter | |
Comment 2•7 years ago
|
||
The question would be how to aggregate the markers that are spread across thread-pools into an analysis of dropped frames for one video.
Closing this in favor of the original implementation and will follow up separately.
Description
•