1548076 - Zoom hotkeys are inconsistent when developer tools are open

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[dmurvihill]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

On any page, open developer tools
Cmd + '+' to zoom in
Cmd + '-' to zoom out.

Actual results:

Web page zoomed in
Developer tools zoomed out

Expected results:

One pane or the other should zoom in and out, depending on which one has focus

Comment 1

[Peter Magyari (Desktop QA)]

Hi,

I wasn't able to reproduce this issue using Firefox 66.0.4(2019-05-04) or Firefox Nightly 68.0a1(2019-05-06)

Please test if the issue occurs in Safe mode. Here is a link that can help you with that:
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

If the issue still occurs, please test it using a new profile, you can find the steps to do that below:
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

Thank you for reporting!

Comment 2

[dmurvihill]

Reproduced in both safe mode and with a new profile.

It appears FireFox behaves normally when the focus is on the content window. The incorrect behavior occurs when the focus is on the developer tools window. The zoom in button still zooms in the page but it should zoom in the developer tools instead.

Comment 3

[Peter Magyari (Desktop QA)]

I cannot reproduce this issue on Firefox 66.0.5 or Firefox Nightly 68.0a1, it does only zoom the focused window on my end.
I will add a component in order to involve the development team in reviewing this issue.

Comment 4

[Patrick Brosset <:pbro>]

I can't reproduce either.
Here are my steps:

• open a page

• open DevTools

• click inside the content page (to make sure focus is there)

• press Cmd + to zoom in ==> the page zooms in, which is expected. DevTools does not, which is expected too.

• click inside DevTools (to make sure focus is there)

• press Cmd + to zoom in ==> the DevTools toolbox zooms in, which is expected. The content page does not, which is expected too.

Now, I did notice one buggy case:

• click in the page to move the focus there
• now click somewhere in the toolbar of DevTools (where the tools are listed)
• press Cmd + ==> the page zooms in, which is not expected.

Are you getting something different dmurvihill?

Comment 5

[Herpiko Dwi Aguno]

Are you getting something different dmurvihill?

I can reproduce this. If we clcik on the blank spot of tool tabs, it won't focus on devtool.

Can I work on this?

Comment 6

[Herpiko Dwi Aguno]

Attachment: Bug 1548076. Try to focus on devtool even if the click hit blank spot on tool tabs. r=pbro

Comment 7

[Herpiko Dwi Aguno]

Attachment: Bug 1548076. Let the devtools gain focus even if the click hits an empty area on UI. r=jdescottes

Comment 8

[dmurvihill]

(In reply to Patrick Brosset <:pbro> (off until July 22nd) from comment #4)

I can't reproduce either.
Here are my steps:

• open a page

• open DevTools

• click inside the content page (to make sure focus is there)

• press Cmd + to zoom in ==> the page zooms in, which is expected. DevTools does not, which is expected too.

• click inside DevTools (to make sure focus is there)

• press Cmd + to zoom in ==> the DevTools toolbox zooms in, which is expected. The content page does not, which is expected too.

Now, I did notice one buggy case:

• click in the page to move the focus there
• now click somewhere in the toolbar of anywhere in DevTools (where the tools are listed)
• press Cmd + ==> the page zooms in, which is not expected.

Are you getting something different dmurvihill?

I followed your procedure exactly. In the final step, the content page zoomed in and DevTools did not -- the opposite of the behavior you reported.

The buggy case you pointed out is occurring for me in all cases, regardless of where I click inside the tool window.

Comment 9

[dmurvihill]

New, very interesting info I discovered just now:

Cmd + in the dev window zooms in the content page
Cmd = (same key, don't touch Shift) in the dev window zooms in the dev tools.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a22e6caaafe1
Let the devtools gain focus even if the click hits an empty area on UI. r=jdescottes,yzen

Comment 11

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a22e6caaafe1