Closed Bug 1548098 Opened 1 year ago Closed 1 year ago

Implement Runtime.callFunctionOn

Categories

(Remote Protocol :: Runtime, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 2 open bugs)

Details

Attachments

(5 files)

https://chromedevtools.github.io/devtools-protocol/tot/Runtime#method-callFunctionOn
Runtime.callFunctionOn
Calls function with given declaration on the given object. Object group of the result is inherited from the target object.

This is necessary in order to support puppeteer's Page.navigate (puppeteer sources)

Assignee: nobody → poirot.alex
Priority: -- → P2
Priority: P2 → P1
Status: NEW → ASSIGNED

This will be used in the next changeset.

Attachment #9063335 - Attachment description: Bug 1548098 - Implement Runtime.callFunctionOn's objectId argument. → Bug 1548098 - Implement Runtime.callFunctionOn's awaitPromise argument.
Attachment #9063331 - Attachment description: Bug 1548098 - Pull out exception handling into a dedicated _returnException method. → Bug 1548098 - Pull out exception handling into a dedicated _returnError method.
Attachment #9063335 - Attachment description: Bug 1548098 - Implement Runtime.callFunctionOn's awaitPromise argument. → Bug 1548098 - Implement Runtime.callFunctionOn's objectId argument.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8a4f66d71d8
Pull out exception handling into a dedicated _returnError method. r=remote-protocol-reviewers,ato
https://hg.mozilla.org/integration/autoland/rev/a0cb02173721
Implement Runtime.callFunctionOn. r=remote-protocol-reviewers,ato
https://hg.mozilla.org/integration/autoland/rev/55505348c64f
Implement Runtime.callFunctionOn's returnByValue argument. r=remote-protocol-reviewers,ato
https://hg.mozilla.org/integration/autoland/rev/087726ba0d15
Implement Runtime.callFunctionOn's awaitPromise argument. r=remote-protocol-reviewers,ato
https://hg.mozilla.org/integration/autoland/rev/d1985ca4a9e2
Implement Runtime.callFunctionOn's objectId argument. r=remote-protocol-reviewers,ato
You need to log in before you can comment on or make changes to this bug.