154814 - [ActiveX] clean up basic DOM functionality

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: ActiveX Wrapper, defect)

Description

[Adam Lock]

The DOM source code is very crusty, overly complicated and needs to be updated
to use Mozilla naming conventions and efficient use of Mozilla classes (e.g. not
use nsString for local string variables).

Ensure all basic functionality from traversal, setting/getting arributes,
get_all, (& get_embeds, etc.), open, close, write, writeln are working properly.
Add a
basic style object implementation. Investigate if script handlers (onclick,
onload etc.) can be made to work.

Add tests CBrowse to exercise the DOM more thoroughly

Comment 1

[Adam Lock]

Attachment: Work in progress

Lot's of cleanup, not tested thoroughly yet

Comment 2

[Adam Lock]

New patch uses DOM walker object

Comment 3

[Adam Lock]

Attachment: Patch

New patch considerably cleans up implementation, and should be more efficient.
Made control and performance *much* faster in debug by commenting out #define
_ATL_DEBUG_INTERFACES

Comment 4

[Adam Lock]

Attachment: Patch

Patch uses the DOM2 standard TreeWalker class instead of the proprietary
nsDOMWalker from webbrowserpersist (which is defunct).

Comment 5

[Chak Nanga]

Comment on attachment 90241 [details] [diff] [review]
Patch

r=chak

Comment 6

[Alec Flett]

Comment on attachment 90241 [details] [diff] [review]
Patch

I don't know much about OLE2W, but could you be using nsDependentString
szName(OLE2W(strAttributeName)) or anything?

other than that, this looks fine. sr=alecf either way.

Comment 7

[Adam Lock]

OLE2W and the other FOO2BAR macros can potentially use temporary variables so I
don't want to risk it.

Fix is checked in

Comment 8

[Michael Dunn]

to ashish for verification

Comment 9

[Ashish Bhatt]

marking as  verified