Closed
Bug 1548146
Opened 5 years ago
Closed 5 years ago
Tweak sLastForgetSkippableCycleEndTime handling to be able to check two tasks within < 1ms
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
Currently TimeUntilNow usage is such that it returns 0 and we just treat that as if sLastForgetSkippableCycleEndTime wasn't set.
But Now() - sLastForgetSkippableCycleEndTime can in fact be 0, and should be treated as such.
This doesn't show up normally too often, but with some other patches I'm evaluating, this might become an issue.
moz-phab doesn't work on this machine, so need to upload patch here the good old way.
|
Assignee | |
Comment 1•5 years ago
|
||
Comment on attachment 9061788 [details] [diff] [review] fs_tweak.diff Misusing data-review flag here :)
Attachment #9061788 -
Flags: data-review?(continuation)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9061788 [details] [diff] [review] fs_tweak.diff Review of attachment 9061788 [details] [diff] [review]: ----------------------------------------------------------------- Hmm the fuzzers found some kind of assertion failure in this code. I don't remember where exactly.
Attachment #9061788 -
Flags: data-review?(continuation) → review+
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/628585931d03 Tweak sLastForgetSkippableCycleEndTime handling to be able to check two tasks within < 1ms, r=mccr8
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•