Tweak sLastForgetSkippableCycleEndTime handling to be able to check two tasks within < 1ms

RESOLVED FIXED in Firefox 68

Status

()

enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

(Blocks 1 bug)

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Posted patch fs_tweak.diffSplinter Review

Currently TimeUntilNow usage is such that it returns 0 and we just treat that as if sLastForgetSkippableCycleEndTime wasn't set.
But Now() - sLastForgetSkippableCycleEndTime can in fact be 0, and should be treated as such.

This doesn't show up normally too often, but with some other patches I'm evaluating, this might become an issue.

moz-phab doesn't work on this machine, so need to upload patch here the good old way.

Comment on attachment 9061788 [details] [diff] [review]
fs_tweak.diff

Misusing data-review flag here :)
Attachment #9061788 - Flags: data-review?(continuation)
Comment on attachment 9061788 [details] [diff] [review]
fs_tweak.diff

Review of attachment 9061788 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm the fuzzers found some kind of assertion failure in this code. I don't remember where exactly.
Attachment #9061788 - Flags: data-review?(continuation) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/628585931d03
Tweak sLastForgetSkippableCycleEndTime handling to be able to check two tasks within < 1ms, r=mccr8
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Blocks: 1547950
You need to log in before you can comment on or make changes to this bug.