1548194 - --enable-warnings-as-errors fails due to -D unused-mut with Rust 1.36

Status: RESOLVED DUPLICATE of bug 1550556

(Core :: XPCOM, defect)

Description

[Jan Beich]

$ rustc -vV
rustc 1.36.0-nightly
binary: rustc
commit-hash: 00859e3e653973120006aaf3227823062dde1ba7
commit-date: 2019-04-29
host: x86_64-unknown-freebsd
release: 1.36.0-nightly
LLVM version: 8.0

$ echo "ac_add_options --enable-warnings-as-errors" >>.mozconfig
$ ./mach build
[...]
error: variable does not need to be mutable
--> xpcom/rust/nsstring/src/conversions.rs:357:17
|
357 | let mut handle = unsafe { self.bulk_write(new_len, old_len, false)? };
| ----^^^^^^
| |
| help: remove this mut
|
= note: -D unused-mut implied by -D warnings
error: variable does not need to be mutable
--> xpcom/rust/nsstring/src/conversions.rs:629:21
|
629 | let mut handle = unsafe { self.bulk_write(new_len, old_len, false)? };
| ----^^^^^^
| |
| help: remove this mut
error: aborting due to 2 previous errors
error: Could not compile nsstring.

Comment 1

[Nathan Froyd [:froydnj]]

I have a patch for this over in bug 1550556.