Closed Bug 1548197 Opened 5 months ago Closed 5 months ago

--enable-warnings-as-errors fails due to -D unused-mut with Rust 1.36

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jbeich, Assigned: kats)

References

Details

Attachments

(1 file)

$ rustc -vV
rustc 1.36.0-nightly
binary: rustc
commit-hash: 00859e3e653973120006aaf3227823062dde1ba7
commit-date: 2019-04-29
host: x86_64-unknown-freebsd
release: 1.36.0-nightly
LLVM version: 8.0

$ echo "ac_add_options --enable-warnings-as-errors" >>.mozconfig
$ ./mach build
[...]
error: variable does not need to be mutable
--> gfx/wr/webrender/src/display_list_flattener.rs:943:22
|
943 | let (mut layout, clip_and_scroll) = self.process_common_properties_with_bounds(
| ----^^^^^^
| |
| help: remove this mut
|
= note: -D unused-mut implied by -D warnings
error: variable does not need to be mutable
--> gfx/wr/webrender/src/display_list_flattener.rs:962:22
|
962 | let (mut layout, clip_and_scroll) = self.process_common_properties_with_bounds(
| ----^^^^^^
| |
| help: remove this mut
error: variable does not need to be mutable
--> gfx/wr/webrender/src/display_list_flattener.rs:978:22
|
978 | let (mut layout, clip_and_scroll) = self.process_common_properties_with_bounds(
| ----^^^^^^
| |
| help: remove this mut
error: variable does not need to be mutable
--> gfx/wr/webrender/src/display_list_flattener.rs:1030:22
|
1030 | let (mut layout, clip_and_scroll) = self.process_common_properties_with_bounds(
| ----^^^^^^
| |
| help: remove this mut
error: variable does not need to be mutable
--> gfx/wr/webrender/src/display_list_flattener.rs:1046:22
|
1046 | let (mut layout, clip_and_scroll) = self.process_common_properties_with_bounds(
| ----^^^^^^
| |
| help: remove this mut
error: variable does not need to be mutable
--> gfx/wr/webrender/src/display_list_flattener.rs:1072:22
|
1072 | let (mut layout, clip_and_scroll) = self.process_common_properties_with_bounds(
| ----^^^^^^
| |
| help: remove this mut
error: variable does not need to be mutable
--> gfx/wr/webrender/src/display_list_flattener.rs:1100:22
|
1100 | let (mut layout, clip_and_scroll) = self.process_common_properties_with_bounds(
| ----^^^^^^
| |
| help: remove this mut
error: variable does not need to be mutable
--> gfx/wr/webrender/src/display_list_flattener.rs:1118:22
|
1118 | let (mut layout, clip_and_scroll) = self.process_common_properties_with_bounds(
| ----^^^^^^
| |
| help: remove this mut
error: variable does not need to be mutable
--> gfx/wr/webrender/src/render_backend.rs:878:45
|
878 | if let Some(mut built_scene) = txn.built_scene.take() {
| ----^^^^^^^^^^^
| |
| help: remove this mut
error: aborting due to 9 previous errors
error: Could not compile webrender.

Thanks for filing! I'll have a patch up shortly.

Assignee: nobody → kats
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d9c1fe157813
Remove unused mut instances to fix warnings with rust nightly. r=kvark
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.