1548234 - remove grid usage from comm/mailnews/base/search/content/CustomHeaders.xul

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Khushil Mistry [:khushil324]]

How to navigate to CustomHeaders.xul: Tools | Message Filters - then in the criteria choose to Customize.

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1548234_remove-grid-CustomHeaders.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9061866 [details] [diff] [review]
Bug-1548234_remove-grid-CustomHeaders.patch

Review of attachment 9061866 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok, r=mkmelin

::: mailnews/base/search/content/CustomHeaders.xul
@@ +33,5 @@
>                         flex="1"
>                         onselect="updateRemoveButton();" />
> +    </vbox>
> +    <vbox>
> +      <label value=""/>

Slightly odd thing to do... but then again the input could be redesigned a bit and this wouldn't be an issue.

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1548234_remove-grid-CustomHeaders.patch

Comment 4

[Khushil Mistry [:khushil324]]

Attachment: Screenshot 2019-05-02 at 7.35.46 PM.png

I have updated the patch like this. Is this looks good?

Comment 5

[Magnus Melin [:mkmelin]]

I think the original looked better, so maybe we just go with that for now.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/98a9b8e62d9a
remove grid usage from CustomHeaders.xul. r=mkmelin