1548235 - remove grid usage from comm/mailnews/compose/content/sendProgress.xul

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1548235_remove-grid-sendProgress.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9061874 [details] [diff] [review]
Bug-1548235_remove-grid-sendProgress.patch

Review of attachment 9061874 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/compose/content/sendProgress.xul
@@ +36,3 @@
>            <label id="dialog.status" crop="center"/>
> +        </hbox>
> +        <hbox class="thin-separator" style="display:flex; align-items: stretch;">

For inline styles I'd use space between each specification, but no space inside, like

style="display:flex; align-items:stretch;">

@@ +40,3 @@
>            <hbox pack="end">
>              <label id="dialog.progressText"/>
>            </hbox>

does look like complicated markup just to put the percentage after the progress bar

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1548235_remove-grid-sendProgress.patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9062253 [details] [diff] [review]
Bug-1548235_remove-grid-sendProgress.patch

Review of attachment 9062253 [details] [diff] [review]:
-----------------------------------------------------------------

I think it's almost correct, but there is some misalingnment. 

I'm just calling window.openDialog("chrome://messenger/content/messengercompose/sendProgress.xul"); from the console. The progress bar is now thicker than it used to be, and aligned with bottom of the progress text

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1548235_de-grid-sendProgress.patch

Comment 6

[Khushil Mistry [:khushil324]]

Attachment: Screenshot 2019-05-06 at 7.44.00 PM.png

Now, it is looking like this.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9062952 [details] [diff] [review]
Bug-1548235_de-grid-sendProgress.patch

Review of attachment 9062952 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin
Doesn't seem to show the problem in "real" usage

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ee74021d18f5
remove grid usage from sendProgress.xul. r=mkmelin