Closed
Bug 1548238
Opened 6 years ago
Closed 6 years ago
Dark preferences mode: use lighter icons on spinbuttons and info-icon
Categories
(Thunderbird :: Theme, enhancement)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 68.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
|
6.03 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
The spinbuttons have still a black arrow with the dark in-content theme. Also the info icon in Advanced > Update has not so much contrast.
|
Assignee | |
Comment 1•6 years ago
|
||
To test with dark mode set the prefs browser.in-content.dark-mode to true and ui.systemUsesDarkTheme to 1.
I changed the spinbutton arrow to use the same shape as the other arrows (dropdown arrow) in the prefs.
Removing the indentation of the @media (prefers-color-scheme: dark) {} block is to be in sync with m-c.
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9061862 [details] [diff] [review]
1548238-dark-mode-icon-fix.patch
Looks very nice with the patch applied. Sorry about the delay.
Attachment #9061862 -
Flags: review?(jorgk) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2b994024f3e2
Dark preferences mode: use lighter icons on spinbuttons and info-icon. r=jorgk
|
|
||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 68.0
You need to log in
before you can comment on or make changes to this bug.
Description
•