1548268 - Improve accessibility of trailhead flow

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ed Lee :Mardak]

• turn on linter (bug 1511152)
• aria-hidden=true for content behind modal
• keep tabbing focus inside modal
• automatically focus email input
• role=dialog on modal with aria-labelledby=<id of heading>
• allow keyboard escape from dialog (bug 1548267)

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

I'm also happy to look at it again in more detail once things on the list are addressed.

In the meanwhile, just like with dialog semantics I would also generally pay attention to semantics of other widgets/controls/etc within the new UI and text alternatives for non-textual bits where needed.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4962

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4987

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

FYI, I looked at colour contrast and there are no issues with onboarding dialog or the cards that show up after it's dismissed.

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/690025a0dcd5

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190509214305) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, the "First Run" page elements are respecting the specs from comment 0.

Comment 7

[Ed Lee :Mardak]

Marking verified as per bug 1550098 Comment 13 for bugs that were status-firefox68=verified