DataChannel::GetOrdered makes a racy access to DataChannel::mFlags

RESOLVED FIXED in Firefox 68

Status

()

defect
P2
normal
Rank:
15
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: bwc, Assigned: bwc)

Tracking

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

This code is called on main:

https://searchfox.org/mozilla-central/rev/f0ef51bfafc8ad0c3a2f523bf076edc57dc4891a/netwerk/sctp/datachannel/DataChannel.h#426-428

But mFlags is generally updated on not-main. There may be additional problems with mFlags.

We will probably want to have a bool mOrdered in DataChannel that is set based on c'tor arguments, and calculate mFlags internally in the c'tor instead of in DataChannelConnection.

Assignee: nobody → docfaraday
Rank: 15
Blocks: 1529695
Depends on: 1529612

Try looks good.

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c75e0b9c3a1c
Don't look at mFlags in GetOrdered (since this is called on main). r=mjf
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.