Closed Bug 1548272 Opened 5 years ago Closed 5 years ago

DataChannel::GetOrdered makes a racy access to DataChannel::mFlags

Categories

(Core :: WebRTC: Networking, defect, P2)

Product:
Core
Component:
WebRTC: Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: bwc, Assigned: bwc)

References

Details

Attachments

(1 file)

Bug 1548272: Don't look at mFlags in GetOrdered (since this is called on main). r?mjf
47 bytes, text/x-phabricator-request
Details | Review

This code is called on main:

https://searchfox.org/mozilla-central/rev/f0ef51bfafc8ad0c3a2f523bf076edc57dc4891a/netwerk/sctp/datachannel/DataChannel.h#426-428

But mFlags is generally updated on not-main. There may be additional problems with mFlags.

We will probably want to have a bool mOrdered in DataChannel that is set based on c'tor arguments, and calculate mFlags internally in the c'tor instead of in DataChannelConnection.

Assignee: nobody → docfaraday
Rank: 15
Blocks: 1529695
Depends on: 1529612

Try looks good.

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c75e0b9c3a1c
Don't look at mFlags in GetOrdered (since this is called on main). r=mjf

https://hg.mozilla.org/mozilla-central/rev/c75e0b9c3a1c

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.