1548272 - DataChannel::GetOrdered makes a racy access to DataChannel::mFlags

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Byron Campen [:bwc]]

This code is called on main:

https://searchfox.org/mozilla-central/rev/f0ef51bfafc8ad0c3a2f523bf076edc57dc4891a/netwerk/sctp/datachannel/DataChannel.h#426-428

But mFlags is generally updated on not-main. There may be additional problems with mFlags.

Comment 1

[Byron Campen [:bwc]]

We will probably want to have a bool mOrdered in DataChannel that is set based on c'tor arguments, and calculate mFlags internally in the c'tor instead of in DataChannelConnection.

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1548272: Don't look at mFlags in GetOrdered (since this is called on main). r?mjf

Depends on D28528

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d94fd40562cb6b98e8c36cd495b17b225023cb11

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=799899d5a99f766c3d0ffeac9cc445f055153d8c

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b8e35cfa80ef45ff6918268847e2f5c78f14f15

Comment 6

[Byron Campen [:bwc]]

Try looks good.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c75e0b9c3a1c
Don't look at mFlags in GetOrdered (since this is called on main). r=mjf

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c75e0b9c3a1c