Closed Bug 1548305 Opened 6 months ago Closed 6 months ago

Maybe<JSAutoRealm> usage in Element::Animate is wrong

Categories

(Core :: DOM: Animation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

It's conditioning on compartment, which is not going to do the right thing in the same-compartment-different-realm case.

Also, for clarity we should use global.Get() here instead or regetting from ownerGlobal.

We just want to enter the Realm unconditionally. Also, we can get the global
from our GlobalObject.

Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cee3233dc4f3
Fix incorrect Maybe<JSAutoRealm> use in Element::Animate. r=jandem
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → bzbarsky
You need to log in before you can comment on or make changes to this bug.