1548317 - Expand arrows (theme-twisty) should be white in selected rows

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect, P3)

Description

[Florens Verschelde :fvsch]

Attachment: json-viewer-twisty-icon.png

On selected rows, the twisty icon keeps its default gray color. It should be white instead.

Should be straightforward, I'll provide a patch.

Comment 1

[Florens Verschelde :fvsch]

So it looks like this is affecting several tabs in Network details too.
The Accessibility panel uses the TreeView component too, but rolls its own CSS fix.

Comment 2

[Florens Verschelde :fvsch]

Attachment: Bug 1548317 - Fix twisty color in selected TreeView rows; r=honza,yzen

Changes impact theme-twisty icons in the TreeView component:

• Make sure theme-twisty uses the selection color (white) in selected rows;
  but override that style for Network details accordion headers.
• Improve the vertical alignment and pixel-perfect icon rendering by
  making sure the icon element takes the full available height (16px)
  and avoiding assymetrical padding (affects the rendering of centered
  background-image, making them blurry on 1x displays).
• Tweak the horizontal spacing of theme-twisty icons so that they take
  up a total of 20px width (similar to what is used in Debugger and
  Inspector), versus 17px previously.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3499107fb6fe
Fix twisty color in selected TreeView rows; r=Honza,yzen

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3499107fb6fe