Closed Bug 1548317 Opened 2 years ago Closed 2 years ago

Expand arrows (theme-twisty) should be white in selected rows

Categories

(DevTools :: JSON Viewer, defect, P3)

defect

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: fvsch, Assigned: fvsch)

Details

Attachments

(2 files)

On selected rows, the twisty icon keeps its default gray color. It should be white instead.

Should be straightforward, I'll provide a patch.

Assignee: nobody → florens
Status: NEW → ASSIGNED

So it looks like this is affecting several tabs in Network details too.
The Accessibility panel uses the TreeView component too, but rolls its own CSS fix.

Changes impact theme-twisty icons in the TreeView component:

  • Make sure theme-twisty uses the selection color (white) in selected rows;
    but override that style for Network details accordion headers.
  • Improve the vertical alignment and pixel-perfect icon rendering by
    making sure the icon element takes the full available height (16px)
    and avoiding assymetrical padding (affects the rendering of centered
    background-image, making them blurry on 1x displays).
  • Tweak the horizontal spacing of theme-twisty icons so that they take
    up a total of 20px width (similar to what is used in Debugger and
    Inspector), versus 17px previously.
Pushed by florens@fvsch.com:
https://hg.mozilla.org/integration/autoland/rev/3499107fb6fe
Fix twisty color in selected TreeView rows; r=Honza,yzen
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.