1548334 - Top Sites site names use part of the URL rather than the site title

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Awesomescreen, enhancement, P2)

Description

[Andreas Bovens [:abovens]]

Attachment: Screenshot_20190501-114954.jpg

When adding a site to Top Sites, the name that is generated consists of bits of the (sub)domain name, rather than of the site title. I expect to see the site title (or a truncated version thereof).

Comment 1

[Chris Peterson [:cpeterson]]

The top site titles are from Tippy Top [1] and hard coded in the new tab [2]. I don't know why the titles aren't capitalized. Perhaps using a lowercase substring of the domain name is a way to avoid L10n?

[1] https://github.com/mozilla/tippy-top-sites
[2] https://searchfox.org/mozilla-central/source/browser/components/newtab/data/content/tippytop/top_sites.json#49

Comment 2

[Devin Reams]

But when you open CNN for example, it also then changes to "edition.cnn" so the domain is coming in somewhere... hmm. To investigate.

Comment 3

[Andrei Teslovan [:ateslovan]]

Attachment: Screenshot from 2019-05-07 14-46-27.png

I investigated this a bit and I do not think that it is an issue on the Android side. What we do in the code to display the Top Sites is just query the database to get the top sites - we don't edit the titles or anything.

Moreover, I can replicate this issue on the desktop version of Firefox as well (see attachment).

That being said, I think this is more of an issue of how they are saved in the first place and not how they are displayed, so it can't be solved on our side.

Comment 4

[Devin Reams]

Thanks, Andrei.

Andreas, since this is consistent with Firefox desktop, do you agree we should consider closing this as wontfix or de-prioritizing it entirely?

Comment 5

[Andreas Bovens [:abovens]]

Sure. Let's close it as wontfix. On a personal note, I'm still curious to understand the inner workings of this feature though.