Tweak sLastCCEndTime handling to be able to check two tasks within < 1ms

RESOLVED FIXED in Firefox 68

Status

()

enhancement
RESOLVED FIXED
3 months ago
14 days ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

(Blocks 1 bug)

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

This is similar to bug 1548146.
I was wondering why I was getting CCs too close to each others after browsing away from youtube.
This would explain why 5% of CYCLE_COLLECTOR_TIME_BETWEEN is 0.

I guess this isn't quite as safe as bug 1548146.

(still away from my main machine, so moz-phab doesn't work. Misusing data-review)

Attachment #9061985 - Flags: data-review?(continuation)
Comment on attachment 9061985 [details] [diff] [review]
sLastCCEndTime_tweak.diff

Review of attachment 9061985 [details] [diff] [review]:
-----------------------------------------------------------------

Should TimeUntilNow just return 0 if the argument is null?
Attachment #9061985 - Flags: data-review?(continuation) → data-review+
Attachment #9061985 - Flags: data-review+ → review+

That is the issue that it returns 0. One can't differentiate null timestamp and < 1ms period.

Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2aa89383ecb5
Tweak sLastCCEndTime handling to be able to check two tasks within < 1ms, r=mccr8
Blocks: 1547950
Type: defect → enhancement
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Which hints that this pushed some GC out from load time, so that bug 1543806 wouldn't get kicked in.

== Change summary for alert #20778 (as of Fri, 03 May 2019 02:53:26 GMT) ==

Improvements:

43% raptor-tp6-reddit-firefox loadtime windows10-64-shippable opt 3,928.25 -> 2,240.46
22% raptor-tp6-reddit-firefox windows10-64-shippable opt 784.05 -> 608.00
16% raptor-tp6-reddit-firefox fcp windows10-64-shippable opt 348.56 -> 294.50
11% raptor-tp6-reddit-firefox loadtime linux64-shippable opt 2,080.54 -> 1,846.17
9% raptor-tp6-reddit-firefox linux64-shippable opt 566.06 -> 513.09
9% raptor-tp6-youtube-firefox loadtime linux64-shippable-qr opt 605.94 -> 553.38
9% raptor-tp6-reddit-firefox fcp linux64-shippable opt 277.15 -> 253.33
5% raptor-tp6-youtube-firefox linux64-shippable-qr opt 308.96 -> 293.23

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=20778

You need to log in before you can comment on or make changes to this bug.