Closed Bug 1548375 Opened 4 months ago Closed 4 months ago

Canvas fingerprinting permission check should log to the page console (not browser console)

Categories

(Core :: Canvas: 2D, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jryans, Assigned: jryans)

Details

Attachments

(3 files)

IsImageExtractionAllowed will print various log messages that would be helpful to site developers, but currently they are routed to the browser console, not the page console, so they will be missed.

In addition, these logs do some extra work to try to find the active script's file and line, but these steps are handled automatically when reporting to the page console.

Assignee: nobody → jryans
Status: NEW → ASSIGNED

By directing fingerprinting logs to the page console (instead of the browser
console), web developers are much more likely to see them and understand what's
wrong.

Now that we're reporting to the page console, there's no need to include the top
document URI, since that's obvious from the tab.

In addition, the script file and line are already added by the console reporting
path (and displayed with nicer formatting), so we don't need to add them to the
message text.

Depends on D29572

Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1376a67f22b4
Send canvas fingerprinting logs to page console. r=baku
https://hg.mozilla.org/integration/autoland/rev/69fb960771d2
Remove redundant canvas log info. r=baku
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.