Logpoint - Double click in secondary pane should open log point panel for editing

RESOLVED FIXED in Firefox 68

Status

defect
P3
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: chujunlu, Assigned: chujunlu)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
Firefox 68
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

2 months ago
Posted image ltF91gYAvy.gif

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.103 Safari/537.36

Steps to reproduce:

STR:
1.Right click on a line
2.Select "Add log"
3.Type in the panel
4.Press enter
5.In secondary pane, Breakpoints session, double click the log point that's just added

Actual results:

AR: The background color of the line that the log point is on changes while clicking.

Expected results:

ER: The log point's panel should open and the input should be in focus, as double clicking on a conditional breakpoint does.
(I'm interested in tackling this if it's a valid issue)

Great find, double-click should work the same between cond and log points.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3
Assignee

Comment 2

2 months ago

I'm on it :)

Thank you Chujun, I really love your excitement!

Let us know if you have any questions.

Assignee: nobody → chujunlu
Status: NEW → ASSIGNED
Keywords: good-first-bug
Assignee

Comment 4

2 months ago

Add an if statement to handle logpoint when double click.
Add Mochitest for both conditional breakpoint and logpoint

Comment 5

2 months ago
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c914f89d395
Double click logpoint in secondary pane opens logpoint panel r=davidwalsh

Comment 6

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.