"Preview landing" button remains green after a landing request has been submitted.
Categories
(Conduit :: Lando, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: KWierso, Unassigned, Mentored)
References
Details
(Keywords: conduit-triaged)
Earlier today, I went to land https://lando.services.mozilla.com/D29560/
I opened that Lando page, clicked the big, green "Preview landing" button, and clicked "Land to integration/autoland". It then brought me back to the main Lando page for that revision, and I went out for lunch.
I came back for lunch and looked at that page in Lando and saw that the big, green "preview landing" button was still green. It took me a while (and seeing the "Landing queued" higher up on the page) to remember that I had already requested a landing earlier in the day.
Glob said this was fixed with 1496105, but I'm still seeing this today.
(Testing with the revision I linked should be safe if you need it. It turns out someone else landed basically the same patch a few hours before I did, so it fails rebasing and rejects landing.)
|
||
Updated•7 years ago
|
|
||
Comment 1•7 years ago
|
||
This is marked as a good-first-bug, how would I go about fixing it?
|
|
||
Comment 2•7 years ago
|
||
Hey :mossop, thanks for the interest. Lando having good-first-bugs and mentored bugs is mainly in preparation to participate in Outreachy next cycle, but some of the other work to smooth out the docs and development environment hasn't been completed yet, so there might be some rough spots in the process. We now use github pull requests for development, so please ignore any documentation that indicates patches should be sent to Phabricator.
The main repositories involved here are mozilla-conduit/lando-ui and mozilla-conduit/lando-api, but you should be able to fix this by only modifying lando-ui. Setup instructions for the dev environment are found here: https://github.com/mozilla-conduit/lando-ui#prerequisites, https://github.com/mozilla-conduit/lando-ui/pull/71/files, and https://github.com/mozilla-conduit/lando-ui/blob/master/how_to_localdev.md
The code relevant to this bug is:
- The markup for that button: https://github.com/mozilla-conduit/lando-ui/blob/61b9dc302ef94af3e2a55c6d200e55cc3fa9fbee/landoui/templates/stack/stack.html#L101-L117
- Example code that makes use of landing attempt statuses in the templates: https://github.com/mozilla-conduit/lando-ui/blob/61b9dc302ef94af3e2a55c6d200e55cc3fa9fbee/landoui/templates/stack/partials/timeline.html#L3-L6
- Where the
transplantsdata comes from that would include the status of the latest landing attempt: https://github.com/mozilla-conduit/lando-ui/blob/61b9dc302ef94af3e2a55c6d200e55cc3fa9fbee/landoui/revisions.py#L179 - The javascript for the button click: https://github.com/mozilla-conduit/lando-ui/blob/61b9dc302ef94af3e2a55c6d200e55cc3fa9fbee/landoui/assets_src/js/components/LandingPreview.js#L15
- CSS for the button: https://github.com/mozilla-conduit/lando-ui/blob/61b9dc302ef94af3e2a55c6d200e55cc3fa9fbee/landoui/assets_src/css/pages/StackPage.scss#L89-L123
The way I would suggest fixing this is by pulling out the status of the last transplant (that is, the last attempt to land) and adding another conditional to the button's markup in stack.html which checks the status. This would go just before the else case, and if the attempt is in progress, style the button differently. It'd probably be easier to just grab this status in the python code and add an additional context variable to rendering the template, but doing it fully in the template works too.
Reading this back, I think this might be more of a good-second-bug or just a mentored bug, so I'm removing the keyword. That being said, pull requests are welcome and I'm happy to answer any more questions or provide more guidance. Feel free to assign this to yourself if you'd still like to fix it.
Description
•