Closed Bug 1548440 Opened 5 years ago Closed 5 years ago

[File a new bug if this happens again] browser_doorhanger_* | The PanelUI.notificationPanel.state should equal open - Got closed, expected open

Categories

(Toolkit :: Application Update, defect, P5)

Product:
Toolkit
Component:
Application Update
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 --- affected

People

(Reporter: intermittent-bug-filer, Assigned: robert.strong.bugs)

References

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

Bug 1548440 - add back app.update.idletime = 0 to the doorhanger tests. r=bytesized
47 bytes, text/x-phabricator-request
Details | Review

Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=244077888&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/V-rp58jdQ5-801uYAhbTrg/runs/0/artifacts/public/logs/live_backing.log

task 2019-05-02T02:45:21.991Z] 02:45:21 INFO - TEST-START | toolkit/mozapps/update/tests/browser/browser_doorhanger_sp_patch_partialApplyFailure_complete_staging.js
[task 2019-05-02T02:45:42.689Z] 02:45:42 INFO - TEST-INFO | started process screentopng
[task 2019-05-02T02:45:43.220Z] 02:45:43 INFO - TEST-INFO | screentopng: exit 0
[task 2019-05-02T02:45:43.221Z] 02:45:43 INFO - Buffered messages logged at 02:45:22
[task 2019-05-02T02:45:43.222Z] 02:45:43 INFO - Entering test bound setupTestCommon
[task 2019-05-02T02:45:43.223Z] 02:45:43 INFO - Leaving test bound setupTestCommon
[task 2019-05-02T02:45:43.224Z] 02:45:43 INFO - Entering test bound doorhanger_sp_patch_partialApplyFailure_complete_staging
[task 2019-05-02T02:45:43.225Z] 02:45:43 INFO - Buffered messages logged at 02:45:42
[task 2019-05-02T02:45:43.226Z] 02:45:43 INFO - 02:45:42:676 | TEST-INFO | chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js | [runDoorhangerUpdateTest/processDoorhangerStep/< : 539] Waiting on PanelUI.notificationPanel.state to equal open - timed out after 200 tries.
[task 2019-05-02T02:45:43.227Z] 02:45:43 INFO - Buffered messages finished
[task 2019-05-02T02:45:43.229Z] 02:45:43 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_doorhanger_sp_patch_partialApplyFailure_complete_staging.js | The PanelUI.notificationPanel.state should equal open - Got closed, expected open
[task 2019-05-02T02:45:43.230Z] 02:45:43 INFO - Stack trace:
[task 2019-05-02T02:45:43.231Z] 02:45:43 INFO - chrome://mochikit/content/browser-test.js:test_is:1325
[task 2019-05-02T02:45:43.232Z] 02:45:43 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runDoorhangerUpdateTest/processDoorhangerStep/<:541
[task 2019-05-02T02:45:43.233Z] 02:45:43 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:processDoorhangerStep:571
[task 2019-05-02T02:45:43.234Z] 02:45:43 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runDoorhangerUpdateTest/<:609
[task 2019-05-02T02:45:43.235Z] 02:45:43 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runDoorhangerUpdateTest:611
[task 2019-05-02T02:45:43.236Z] 02:45:43 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/browser_doorhanger_sp_patch_partialApplyFailure_complete_staging.js:doorhanger_sp_patch_partialApplyFailure_complete_staging:24
[task 2019-05-02T02:45:43.236Z] 02:45:43 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-05-02T02:45:43.238Z] 02:45:43 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-05-02T02:45:43.238Z] 02:45:43 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-05-02T02:45:43.239Z] 02:45:43 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-05-02T02:45:43.244Z] 02:45:43 INFO - Not taking screenshot here: see the one that was previously logged

Note: this is on Linux ASAN

Summary: Intermittent toolkit/mozapps/update/tests/browser/browser_doorhanger_sp_patch_partialApplyFailure_complete_staging.js | The PanelUI.notificationPanel.state should equal open - Got closed, expected open → Intermittent toolkit/mozapps/update/tests/browser/browser_doorhanger_sp_* | The PanelUI.notificationPanel.state should equal open - Got closed, expected open

This was erroneously removed in bug 1546597.
Also restores the original order of writing to the update.status file in relation to reloading the update manager.

Summary: Intermittent toolkit/mozapps/update/tests/browser/browser_doorhanger_sp_* | The PanelUI.notificationPanel.state should equal open - Got closed, expected open → Intermittent toolkit/mozapps/update/tests/browser/browser_doorhanger_* | The PanelUI.notificationPanel.state should equal open - Got closed, expected open
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c078e2cefc3b
add back app.update.idletime = 0 to the doorhanger tests. r=bytesized

https://hg.mozilla.org/mozilla-central/rev/c078e2cefc3b

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

This looks like it's still happening: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=244764103&repo=autoland&lineNumber=24151

Th push: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cdebug%2Cmochitests%2Ctest-linux32%2Fdebug-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&tochange=e86a75908fd3f530563496cee8777f0e64e3fd20&fromchange=c078e2cefc3b86e17f1495c13a33aa58dc26be06&selectedJob=244764103

[task 2019-05-05T23:19:05.734Z] 23:19:05 INFO - TEST-INFO | started process screentopng
[task 2019-05-05T23:19:06.278Z] 23:19:06 INFO - TEST-INFO | screentopng: exit 0
[task 2019-05-05T23:19:06.278Z] 23:19:06 INFO - Buffered messages logged at 23:18:42
[task 2019-05-05T23:19:06.278Z] 23:19:06 INFO - Entering test bound setupTestCommon
[task 2019-05-05T23:19:06.278Z] 23:19:06 INFO - Leaving test bound setupTestCommon
[task 2019-05-05T23:19:06.278Z] 23:19:06 INFO - Entering test bound doorhanger_sp_patch_completeApplyFailure
[task 2019-05-05T23:19:06.282Z] 23:19:06 INFO - Buffered messages logged at 23:19:05
[task 2019-05-05T23:19:06.282Z] 23:19:06 INFO - 23:19:05:717 | TEST-INFO | chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js | [runDoorhangerUpdateTest/processDoorhangerStep/< : 542] Waiting on PanelUI.notificationPanel.state to equal open - timed out after 200 tries.
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - Buffered messages finished
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/update/tests/browser/browser_doorhanger_sp_patch_completeApplyFailure.js | The PanelUI.notificationPanel.state should equal open - Got closed, expected open
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - Stack trace:
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - chrome://mochikit/content/browser-test.js:test_is:1325
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runDoorhangerUpdateTest/processDoorhangerStep/<:544
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:processDoorhangerStep:574
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runDoorhangerUpdateTest/<:613
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/head.js:runDoorhangerUpdateTest:615
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - chrome://mochitests/content/browser/toolkit/mozapps/update/tests/browser/browser_doorhanger_sp_patch_completeApplyFailure.js:doorhanger_sp_patch_completeApplyFailure:14
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-05-05T23:19:06.283Z] 23:19:06 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-05-05T23:19:06.286Z] 23:19:06 INFO - Not taking screenshot here: see the one that was previously logged

Flags: needinfo?(robert.strong.bugs)
Status: RESOLVED → REOPENED
status-firefox66: --- → unaffected
status-firefox67: --- → unaffected
status-firefox68: fixed → affected
status-firefox-esr60: --- → unaffected
Resolution: FIXED → ---
Target Milestone: mozilla68 → ---
Flags: needinfo?(robert.strong.bugs)

Now that we have the app update intermittent failures under control again please file individual bugs if this fails again.

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → WORKSFORME
Summary: Intermittent toolkit/mozapps/update/tests/browser/browser_doorhanger_* | The PanelUI.notificationPanel.state should equal open - Got closed, expected open → [File a new bug if this happens again] browser_doorhanger_* | The PanelUI.notificationPanel.state should equal open - Got closed, expected open
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: