Minor cleanup (reduce uses of ScrollableLayerGuid)
Categories
(Core :: Panning and Zooming, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
Details
Attachments
(2 files)
While working on bug 1524232 I found some cleanup opportunities because we pass around a ScrollableLayerGuid in a couple of places where we don't really need to.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D29687
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dadb3b3dad5f Cleanup to stop passing around a guid when we only need a layers id. r=botond https://hg.mozilla.org/integration/autoland/rev/b7d27dc874df Cleanup to remove unused guid parameter in callback. r=botond
|
||
Comment 5•5 years ago
|
||
Backed out 2 changesets (bug 1548568) for Valgrind failure. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=244959901&repo=autoland&lineNumber=40320
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=b7d27dc874dfc46fcd4455bd4ad2ccddf3e5e754
Backout:
https://hg.mozilla.org/integration/autoland/rev/39077226dac335e743f7465fb91349d76ded1922
|
|
Assignee | |
Comment 6•5 years ago
•
|
||
If I'm reading TH correctly, this backout didn't fix the valgrind failure, but the backout of bug 1548941 did. So this bug was not at fault, and can reland.
Edit: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Copt%2Cvalgrind-linux64-valgrind%2Fopt%2C%28v%29&fromchange=088d7221c75aa84d4a3ad559e50e1dc99bfd9fa1&tochange=4574274db3f95575dca7da08e16d6f20242fcb2a is the relevant range.
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a51bea90b886 Cleanup to stop passing around a guid when we only need a layers id. r=botond https://hg.mozilla.org/integration/autoland/rev/7748746bf2fe Cleanup to remove unused guid parameter in callback. r=botond
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a51bea90b886
https://hg.mozilla.org/mozilla-central/rev/7748746bf2fe
Description
•