Closed Bug 1548568 Opened 9 months ago Closed 9 months ago

Minor cleanup (reduce uses of ScrollableLayerGuid)

Categories

(Core :: Panning and Zooming, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(2 files)

While working on bug 1524232 I found some cleanup opportunities because we pass around a ScrollableLayerGuid in a couple of places where we don't really need to.

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dadb3b3dad5f
Cleanup to stop passing around a guid when we only need a layers id. r=botond
https://hg.mozilla.org/integration/autoland/rev/b7d27dc874df
Cleanup to remove unused guid parameter in callback. r=botond

If I'm reading TH correctly, this backout didn't fix the valgrind failure, but the backout of bug 1548941 did. So this bug was not at fault, and can reland.

Edit: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Copt%2Cvalgrind-linux64-valgrind%2Fopt%2C%28v%29&fromchange=088d7221c75aa84d4a3ad559e50e1dc99bfd9fa1&tochange=4574274db3f95575dca7da08e16d6f20242fcb2a is the relevant range.

Flags: needinfo?(kats)
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a51bea90b886
Cleanup to stop passing around a guid when we only need a layers id. r=botond
https://hg.mozilla.org/integration/autoland/rev/7748746bf2fe
Cleanup to remove unused guid parameter in callback. r=botond
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.