1548574 - [mozproxy] mitmproxy failing to start when using both 2.x and 4.x in same test job

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Robert Wood [:rwood]]

Looks like there is an issue where mozproxy fails to startup when using two different versions of mitmproxy (i.e. 2.x, 4.x) in the same tp6 suite.

:jmaher noticed that the Raptor tp6-8 Firefox jobs are actually failing (although they appear green):

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=raptor%2Ctp6-8&selectedJob=244047942

Note that a bug is already on file for the fact the jobs themselves appear green but should be red, and will be fixed separately (Bug 1548477).

You'll see in the tp6-8 config that both versions of mitmproxy are used in the same suite:

https://searchfox.org/mozilla-central/source/testing/raptor/raptor/tests/raptor-tp6-8.ini

Comment 1

[Robert Wood [:rwood]]

:bebe, :tarek: would you please have a look? Thanks!

Comment 2

[Tarek Ziadé (:tarek)]

One solution would be to rename the binary so they include the version number in the executable name. What do you think Bebe?

Comment 3

[Florin Strugariu [:Bebe]]

:tarek we could just create a version based folder where to download the bin file. That would avoid re-uploading

Comment 4

[Florin Strugariu [:Bebe]]

Attachment: Bug 1548574 [mozproxy] mitmproxy failing to start when using both 2.x and 4.x in same test job

Comment 5

[Florin Strugariu [:Bebe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=29d2ae9c7c53c433447392ae9b85222ffa5952c9

try build

Comment 6

[Florin Strugariu [:Bebe]]

new try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f0e5d07b67cc9fb5400588befbfba15adece52b

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26561f2b9384
[mozproxy] mitmproxy failing to start when using both 2.x and 4.x in same test job r=tarek

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/26561f2b9384