Closed Bug 1548593 Opened 5 years ago Closed 4 months ago

[meta] Target.attachToTarget

Categories

(Remote Protocol :: CDP, task)

Product:
Remote Protocol
Component:
CDP
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: ato, Unassigned)

References

(
URL
)

Details

(Keywords: meta, Whiteboard: [method=Target.attachToTarget])

No description provided.
Blocks: puppeteer-mvp
URL: https://chromedevtools.github.io/devt...
Keywords: meta
Whiteboard: [method=Target.attachToTarget]
Depends on: 1533682
Blocks: puppeteer

The basic support as implemented only covers the targetId argument but not the optional flatten argument.

Puppeteer sets flatten to true inside of Connection.createSession(), which is used by the callback for Target.targetCreated as setup inside of Browser.constructor. And Gutenberg makes use of that.

I will file a new bug for flatten which should block the alpha release.

This bug we should be able to close as fixed once the to file bug has been fixed.

No longer blocks: puppeteer-mvp
Component: CDP: Target → CDP
Severity: normal → S3

Everything we could do for CDP is done.

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.