Closed Bug 1548639 Opened 3 years ago Closed 3 years ago

Search engine default checks for locale with "startsWith" are broken

Categories

(Firefox :: Search, defect, P1)

Product:
Firefox
Component:
Search
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Iteration:
68.4 - Apr 29 - May 12
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Bug 1548639 - Fix handling of 'startsWith' checks for the search engine configuration tests.
47 bytes, text/x-phabricator-request
Details | Review

When I wrote the new unit tests in bug 1541210, I made a mistake with the logic for locales that a engine should be included with when using startsWith.

It currently never returns a match for startsWith as the comparison is the wrong way around.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d59bc9316e78
Fix handling of 'startsWith' checks for the search engine configuration tests. r=daleharvey

https://hg.mozilla.org/mozilla-central/rev/d59bc9316e78

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Regressions: 1457984
Iteration: --- → 68.4 - Apr 29 - May 12
You need to log in before you can comment on or make changes to this bug.